From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032AbbGUCum (ORCPT ); Mon, 20 Jul 2015 22:50:42 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:35884 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbbGUCuk (ORCPT ); Mon, 20 Jul 2015 22:50:40 -0400 Message-ID: <55ADB37C.5020306@roeck-us.net> Date: Mon, 20 Jul 2015 19:50:36 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Viresh Kumar CC: Daniel Lezcano , Laurent Pinchart , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' References: <55AD6314.2050000@roeck-us.net> <20150721023114.GD4994@linux> In-Reply-To: <20150721023114.GD4994@linux> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2015 07:31 PM, Viresh Kumar wrote: > On 20-07-15, 14:07, Guenter Roeck wrote: >> Hi, >> >> Commit 991a7f4970ed1 ("clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface") >> in -next causes the following traceback. This is seen with qemu runs for the sh target. >> >> ------------[ cut here ]------------ >> WARNING: at drivers/clocksource/sh_tmu.c:202 >> Modules linked in: > > Can you please try this: > > diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c > index 43c98143f79a..469e776ec17a 100644 > --- a/drivers/clocksource/sh_tmu.c > +++ b/drivers/clocksource/sh_tmu.c > @@ -362,7 +362,8 @@ static int sh_tmu_clock_event_shutdown(struct clock_event_device *ced) > { > struct sh_tmu_channel *ch = ced_to_sh_tmu(ced); > > - sh_tmu_disable(ch); > + if (clockevent_state_oneshot(ced) || clockevent_state_periodic(ced)) > + sh_tmu_disable(ch); > return 0; > } > > This patch fixes the problem. Thanks, Guenter