From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbbGULRz (ORCPT ); Tue, 21 Jul 2015 07:17:55 -0400 Received: from smtp30.i.mail.ru ([94.100.177.90]:46777 "EHLO smtp30.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754075AbbGULRx (ORCPT ); Tue, 21 Jul 2015 07:17:53 -0400 Subject: Re: [PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested To: Florian Fainelli , netdev@vger.kernel.org References: <1437439798-12622-1-git-send-email-f.fainelli@gmail.com> Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, mxs@sbrk.org, arno@natisbad.org, stsp@users.sourceforge.net, devicetree@vger.kernel.org, thomas.petazzoni@free-electrons.com From: Stas Sergeev Message-ID: <55AE2A54.3010701@list.ru> Date: Tue, 21 Jul 2015 14:17:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1437439798-12622-1-git-send-email-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 21.07.2015 03:49, Florian Fainelli пишет: > Hi all, > > Changes in v5: > > - removed an invalid use of the link_update callback in the SF2 driver > was appeared after merging "net: phy: fixed_phy: handle link-down case" Thanks for bringing this forward! For the future, perhaps it will make sense to also teach phylib to never read link status (including speed) when link is down. Will help to narrow more of such problems.