From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755345AbbGUOBx (ORCPT ); Tue, 21 Jul 2015 10:01:53 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:24091 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754568AbbGUOBu (ORCPT ); Tue, 21 Jul 2015 10:01:50 -0400 X-ME-Helo: nestor.ysoft.org X-ME-Auth: eWFubi5jYW50aW4yQHdhbmFkb28uZnI= X-ME-Date: Tue, 21 Jul 2015 15:54:18 +0200 X-ME-IP: 86.201.141.183 Message-ID: <55AE4F06.7000407@laposte.net> Date: Tue, 21 Jul 2015 15:54:14 +0200 From: Yann Cantin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Greg KH , Dmitry Torokhov CC: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, jkosina@suse.cz Subject: Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver References: <1437426199-29866-1-git-send-email-yann.cantin@laposte.net> <1437426199-29866-3-git-send-email-yann.cantin@laposte.net> <20150720215956.GA21796@kroah.com> <20150720222640.GD30252@dtor-ws> <20150720224033.GA23884@kroah.com> In-Reply-To: <20150720224033.GA23884@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le 21/07/2015 00:40, Greg KH a écrit : > On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: >> On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: >>> On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: >>>> Signed-off-by: Yann Cantin >>> >>>> + >>>> + /* sysfs setup */ >>>> + err = sysfs_create_group(&intf->dev.kobj, &ebeam_attr_group); >>> >>> Ick, you just added the sysfs files to the USB device, not your input >>> device, are you sure you tested this? >>> >>> And there should be a race-free way to add an attribute group to an >>> input device, as this is, you are adding them to the device _after_ it >>> is created, so userspace will not see them at creation time, causing a >>> race. >> >> No, there are no driver-specific attributed on input devices themselves, >> they belong to the actual hardware devices. The input devices only >> export standard attributes applicable to every and all input devices >> in the system. > > Then the Documentation in this patch better be fixed up, as it points to > the input device as having these sysfs files :) > > But as these are input device attributes, and not USB device interface > attributes, putting them on the USB interface doesn't make much sense, To sum up : these attributes are USB device's not input's, only indirectly accessed via inputXX/device/, and they only modify the driver's behavior. So, it make sense to correct the documentation to point at /sys/bus/usb/drivers/ebeam/X-X:1.0/. Right ? thanks, -- Yann Cantin A4FEB47F --