From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932583AbbGUO50 (ORCPT ); Tue, 21 Jul 2015 10:57:26 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:51775 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754201AbbGUO5Y (ORCPT ); Tue, 21 Jul 2015 10:57:24 -0400 Message-ID: <55AE5DD4.3060304@ti.com> Date: Tue, 21 Jul 2015 10:57:24 -0400 From: Murali Karicheri Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Nicholas Krause , CC: , Subject: Re: [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes_config References: <1437407684-1750-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1437407684-1750-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2015 11:54 AM, Nicholas Krause wrote: > This fixes error handling in the function netcp_xgbe_serdes_config > by putting the return value of netcp_xgbe_serdes_check_lane into > the variable ret and return this value to the caller as this function > can fail when called by returning the error code -ETIMEOUT. > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/ti/netcp_xgbepcsr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/netcp_xgbepcsr.c b/drivers/net/ethernet/ti/netcp_xgbepcsr.c > index 33571ac..0c79e3d 100644 > --- a/drivers/net/ethernet/ti/netcp_xgbepcsr.c > +++ b/drivers/net/ethernet/ti/netcp_xgbepcsr.c > @@ -483,7 +483,7 @@ static int netcp_xgbe_serdes_config(void __iomem *serdes_regs, > return ret; > > netcp_xgbe_serdes_enable_xgmii_port(sw_regs); > - netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs); > + ret = netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs); > return ret; > } > > Nicholas, Thanks for the patch. Acked-by: Murali Karicheri -- Murali Karicheri Linux Kernel, Keystone