From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756347AbbGVH0q (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jul 2015 03:26:46 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:36664 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755903AbbGVH0n (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jul 2015 03:26:43 -0400
Message-ID: <55AF45AC.9040003@linaro.org>
Date: Wed, 22 Jul 2015 08:26:36 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Stefan Wahren <stefan.wahren@i2se.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org
CC: wxt@rock-chips.com, linux-api@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, sboyd@codeaurora.org, arnd@arndb.de,
        s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
        mporter@konsulko.com, linux-arm-msm@vger.kernel.org,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        pantelis.antoniou@konsulko.com, Mark Brown <broonie@kernel.org>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers
References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403403-4180-1-git-send-email-srinivas.kandagatla@linaro.org> <1590184041.70825.1437495942088.JavaMail.open-xchange@oxbsltgw08.schlund.de>
In-Reply-To: <1590184041.70825.1437495942088.JavaMail.open-xchange@oxbsltgw08.schlund.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Stefan,

On 21/07/15 17:25, Stefan Wahren wrote:
>> +
>> >+ addr = of_get_property(cell_np, "reg", &len);
>> >+ if (!addr || (len < 2 * sizeof(int))) {
> I'm not sure, but shouldn't be sizeof(u32) more portable?
>
yes it makes sense, I will change it.
>> >[...]
>> >+
>> >+ addr = of_get_property(cell_np, "bits", &len);
>> >+ if (addr && len == (2 * sizeof(int))) {
> dito
yep.

--srini