Re: fs: Remove ext3 filesystem driver In-Reply-To: <20150715124709.GA11446@quack.suse.cz>

[Dimitri John Ledkov <dimitri.j.ledkov@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

Heya,

So I did a trimmed export of the patch from repository pointed out, and I have a comment about the config change below. I'm pretty sure i probably got the headers wrong, so sorry if i break threading with this email.

On 18/06/15 15:52, Jan Kara wrote:
> The functionality of ext3 is fully supported by ext4 driver. Major
> distributions (SUSE, RedHat) already use ext4 driver to handle ext3
> filesystems for quite some time. There is some ugliness in mm resulting
> from jbd cleaning buffers in a dirty page without cleaning page dirty
> bit and also support for buffer bouncing in the block layer when stable
> pages are required is there only because of jbd. So let's remove the
> ext3 driver.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> 
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index bf8bc8a..8be84ad 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -28,14 +28,14 @@ config EXT4_FS
>  
>  	  If unsure, say N.
>  
> -config EXT4_USE_FOR_EXT23
> +config EXT4_USE_FOR_EXT2
>  	bool "Use ext4 for ext2/ext3 file systems"
>  	depends on EXT4_FS
> -	depends on EXT3_FS=n || EXT2_FS=n
> +	depends on EXT2_FS=n
>  	default y
>  	help
> -	  Allow the ext4 file system driver code to be used for ext2 or
> -	  ext3 file system mounts.  This allows users to reduce their
> +	  Allow the ext4 file system driver code to be used for ext2
> +	  file system mounts.  This allows users to reduce their
>  	  compiled kernel size by using one file system driver for
>  	  ext2, ext3, and ext4 file systems.

I would prefer not to change the config option name or text, and only change the depends. Cause ext4 driver in fact can be used for ext2/3, and can be used for ext2 or ext3 system mounts. The fact that there isn't an ext3 module anymore, doesn't change ext4 driver.

I presume this option will remain even when both ext2 and ext3 drivers get dropped, such that one can toggle off ext2/3 portions of ext4 driver. Or am I wrong?

-- 
Regards,

Dimitri.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]