From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934446AbbGVOt5 (ORCPT ); Wed, 22 Jul 2015 10:49:57 -0400 Received: from mga03.intel.com ([134.134.136.65]:21095 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933694AbbGVOtz (ORCPT ); Wed, 22 Jul 2015 10:49:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,523,1432623600"; d="asc'?scan'208";a="610780332" Message-ID: <55AFAD8F.3040407@linux.intel.com> Date: Wed, 22 Jul 2015 15:49:51 +0100 From: Dimitri John Ledkov Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jan Kara , linux-kernel@vger.kernel.org Subject: Re: fs: Remove ext3 filesystem driver In-Reply-To: <20150715124709.GA11446@quack.suse.cz> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R14AruXuc5mHuXE0jKOFaQRmkoQpL3Euo" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R14AruXuc5mHuXE0jKOFaQRmkoQpL3Euo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Heya, So I did a trimmed export of the patch from repository pointed out, and I= have a comment about the config change below. I'm pretty sure i probably= got the headers wrong, so sorry if i break threading with this email. On 18/06/15 15:52, Jan Kara wrote: > The functionality of ext3 is fully supported by ext4 driver. Major > distributions (SUSE, RedHat) already use ext4 driver to handle ext3 > filesystems for quite some time. There is some ugliness in mm resulting= > from jbd cleaning buffers in a dirty page without cleaning page dirty > bit and also support for buffer bouncing in the block layer when stable= > pages are required is there only because of jbd. So let's remove the > ext3 driver. >=20 > Signed-off-by: Jan Kara >=20 > diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig > index bf8bc8a..8be84ad 100644 > --- a/fs/ext4/Kconfig > +++ b/fs/ext4/Kconfig > @@ -28,14 +28,14 @@ config EXT4_FS > =20 > If unsure, say N. > =20 > -config EXT4_USE_FOR_EXT23 > +config EXT4_USE_FOR_EXT2 > bool "Use ext4 for ext2/ext3 file systems" > depends on EXT4_FS > - depends on EXT3_FS=3Dn || EXT2_FS=3Dn > + depends on EXT2_FS=3Dn > default y > help > - Allow the ext4 file system driver code to be used for ext2 or > - ext3 file system mounts. This allows users to reduce their > + Allow the ext4 file system driver code to be used for ext2 > + file system mounts. This allows users to reduce their > compiled kernel size by using one file system driver for > ext2, ext3, and ext4 file systems. I would prefer not to change the config option name or text, and only cha= nge the depends. Cause ext4 driver in fact can be used for ext2/3, and ca= n be used for ext2 or ext3 system mounts. The fact that there isn't an ex= t3 module anymore, doesn't change ext4 driver. I presume this option will remain even when both ext2 and ext3 drivers ge= t dropped, such that one can toggle off ext2/3 portions of ext4 driver. O= r am I wrong? --=20 Regards, Dimitri. --R14AruXuc5mHuXE0jKOFaQRmkoQpL3Euo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVr62PAAoJEMrC2LnNLKX5CC4IALPH+p4y0lIbhkKnpZYxUTlG pWnh5gz90Z2+3PChgUepgp0g1l8cG79ZI2eCVBtO5AFg6C3rgqiwqbPkx/8vzxYW PBJ2Kw5mEZVbMS+hC3F2wAMAX0SpBDJKiHwDenuoGKAcLAgLN4ws9pdIsHLXi/Yx u4j0vi8KZF7WpyNm5FohSR3QwIjKhx4f/mZieq4wMGKR50I2q6BcdzTo+uZM7tfG avRrfp1uUZQCPKyQk+h2KFVwGUIfaoD2WHV0j830F3GAZ8o2nbAa9kNSUTKyVLiy 6GtC7FFFmr3MTMBcC6xa3An31KBUuKRbATuIpa2bPEaDPcuH/osBtUe8fYH4PHQ= =64DR -----END PGP SIGNATURE----- --R14AruXuc5mHuXE0jKOFaQRmkoQpL3Euo--