From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934638AbbGVPkf (ORCPT ); Wed, 22 Jul 2015 11:40:35 -0400 Received: from foss.arm.com ([217.140.101.70]:36670 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934181AbbGVPkd (ORCPT ); Wed, 22 Jul 2015 11:40:33 -0400 Message-ID: <55AFB96E.1050406@arm.com> Date: Wed, 22 Jul 2015 16:40:30 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Liviu Dudau CC: Sudeep Holla , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lorenzo Pieralisi , "Jon Medhurst (Tixy)" , Arnd Bergmann , Kevin Hilman , Olof Johansson Subject: Re: [PATCH v4 6/8] arm64: dts: add SRAM, MHU mailbox and SCPI support on Juno References: <1433760002-24120-1-git-send-email-sudeep.holla@arm.com> <1433760002-24120-7-git-send-email-sudeep.holla@arm.com> <20150722132809.GG14923@e106497-lin.cambridge.arm.com> In-Reply-To: <20150722132809.GG14923@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/15 14:28, Liviu Dudau wrote: > On Mon, Jun 08, 2015 at 11:40:00AM +0100, Sudeep Holla wrote: >> This patch adds support for the MHU mailbox peripheral used on Juno by >> application processors to communicate with remote SCP handling most of >> the CPU/system power management. It also adds the SRAM reserving the >> shared memory and SCPI message protocol using that shared memory. >> >> Cc: Liviu Dudau >> Cc: Jon Medhurst (Tixy) >> Signed-off-by: Sudeep Holla >> --- >> arch/arm64/boot/dts/arm/juno-base.dtsi | 31 +++++++++++++++++++++++++++++++ >> arch/arm64/boot/dts/arm/juno-clocks.dtsi | 23 +++++++++++++++++++++++ >> 2 files changed, 54 insertions(+) >> [..] >> diff --git a/arch/arm64/boot/dts/arm/juno-clocks.dtsi b/arch/arm64/boot/dts/arm/juno-clocks.dtsi >> index 25352ed943e6..64af7370815a 100644 >> --- a/arch/arm64/boot/dts/arm/juno-clocks.dtsi >> +++ b/arch/arm64/boot/dts/arm/juno-clocks.dtsi >> @@ -42,3 +42,26 @@ >> clock-frequency = <400000000>; >> clock-output-names = "faxi_clk"; >> }; >> + >> + scpi { >> + compatible = "arm,scpi"; >> + mboxes = <&mailbox 1>; >> + shmem = <&cpu_scp_hpri>; >> + >> + clocks { >> + compatible = "arm,scpi-clocks"; >> + >> + scpi_dvfs: scpi_clocks@0 { >> + compatible = "arm,scpi-dvfs-clocks"; >> + #clock-cells = <1>; >> + clock-indices = <0>, <1>, <2>; >> + clock-output-names = "vbig", "vlittle", "vgpu"; >> + }; >> + scpi_clk: scpi_clocks@3 { >> + compatible = "arm,scpi-variable-clocks"; >> + #clock-cells = <1>; >> + clock-indices = <3>, <4>; > > Subject to you addressing Mark's comments regarding the indices values (maybe choose > a different property to show the fact that the index is actually an SCPI index > rather than the clock's), you can add my > I don't understand why we need to do that. I will anyway follow up on that thread. > Acked-by: Liviu Dudau Thanks for all the ACKs. Regards, Sudeep