Re: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype

[Pan Xinhui <xinhuix.pan@intel.com>]

hi, Elliot
	thanks for your reply.
On 2015年07月22日 22:38, Elliott, Robert (Server Storage) wrote:
> 
> 
> ---
> Robert Elliott, HP Server Storage
> 
>> -----Original Message-----
>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
>> owner@vger.kernel.org] On Behalf Of Pan Xinhui
>> Sent: Wednesday, July 22, 2015 8:27 AM
> ...
>> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
>> index 188e3e0..8fa1f07 100644
>> --- a/arch/x86/mm/pat.c
>> +++ b/arch/x86/mm/pat.c
>> @@ -521,10 +521,7 @@ int reserve_memtype(u64 start, u64 end, enum
>> page_cache_mode req_type,
>>
>>       is_range_ram = pat_pagerange_is_ram(start, end);
>>       if (is_range_ram == 1) {
>> -
>> -             err = reserve_ram_pages_type(start, end, req_type, new_type);
>> -
>> -             return err;
>> +             return reserve_ram_pages_type(start, end, req_type, new_type);
>>       } else if (is_range_ram < 0) {
>>               return -EINVAL;
>>       }
> 
> With each branch now just one line, the {} can be removed.
> 
thanks for the nice tips. sorry for my mistakes.

thanks
xinhui
> 
>