public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
	"open list:EXTERNAL CONNECTOR SUBSYSTEM (EXTCON)" 
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: Drop owner assignment from i2c_driver
Date: Thu, 23 Jul 2015 11:40:09 +0900	[thread overview]
Message-ID: <55B05409.7010805@samsung.com> (raw)
In-Reply-To: <1436507420-13527-1-git-send-email-k.kozlowski@samsung.com>

On 07/10/2015 02:50 PM, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/extcon/extcon-rt8973a.c | 1 -
>  drivers/extcon/extcon-sm5502.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c
> index 92c939221a41..11592e980bc1 100644
> --- a/drivers/extcon/extcon-rt8973a.c
> +++ b/drivers/extcon/extcon-rt8973a.c
> @@ -693,7 +693,6 @@ MODULE_DEVICE_TABLE(i2c, rt8973a_i2c_id);
>  static struct i2c_driver rt8973a_muic_i2c_driver = {
>  	.driver		= {
>  		.name	= "rt8973a",
> -		.owner	= THIS_MODULE,
>  		.pm	= &rt8973a_muic_pm_ops,
>  		.of_match_table = rt8973a_dt_match,
>  	},
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index 817dece23b4c..0ffefefa2e26 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -685,7 +685,6 @@ MODULE_DEVICE_TABLE(i2c, sm5502_i2c_id);
>  static struct i2c_driver sm5502_muic_i2c_driver = {
>  	.driver		= {
>  		.name	= "sm5502",
> -		.owner	= THIS_MODULE,
>  		.pm	= &sm5502_muic_pm_ops,
>  		.of_match_table = sm5502_dt_match,
>  	},
> 

Applied it.

Thanks,
Chanwoo Choi


      reply	other threads:[~2015-07-23  2:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10  5:50 [PATCH] extcon: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-07-23  2:40 ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B05409.7010805@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox