From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
bsd@redhat.com, lersek@redhat.com, jordan.l.justen@intel.com,
edk2-devel@lists.sourceforge.net,
Xiao Guangrong <guangrong.xiao@intel.com>
Subject: Re: [PATCH 3/3] KVM: x86: quirkily apply WB to all memory if cache is disabled
Date: Thu, 23 Jul 2015 14:03:50 +0800 [thread overview]
Message-ID: <55B083C6.503@linux.intel.com> (raw)
In-Reply-To: <55B081F1.50406@redhat.com>
On 07/23/2015 01:56 PM, Paolo Bonzini wrote:
>
>
> On 15/07/2015 21:25, Xiao Guangrong wrote:
>> From: Xiao Guangrong <guangrong.xiao@intel.com>
>>
>> Current firmware depends on WB to fast boot, please refer to
>> https://lkml.org/lkml/2015/7/12/115
>>
>> Let's us WB if CR0.CD is set to make this kind of firmware happy
>>
>> This quirk can be dropped by using KVM_ENABLE_CAP API with
>> KVM_CAP_DISABLE_QUIRKS if the broken firmware is gone
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@intel.com>
>
> Your patch is actually *enabling* the quirk if KVM_QUIRK_CD_AS_WB is
> included in the disabled quirks. I'm squashing in this change:
Yep, i misunderstood the meaning of "disabled-quirks", thanks for your
nice adjustment, Paolo!
next prev parent reply other threads:[~2015-07-23 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 19:25 [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled Xiao Guangrong
2015-07-15 19:25 ` [PATCH 2/3] KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-07-29 19:07 ` Alex Williamson
2015-07-30 7:21 ` [edk2] " Paolo Bonzini
2015-07-15 19:25 ` [PATCH 3/3] KVM: x86: quirkily apply WB to all memory if cache is disabled Xiao Guangrong
2015-07-23 5:56 ` Paolo Bonzini
2015-07-23 6:03 ` Xiao Guangrong [this message]
2015-07-16 4:10 ` [PATCH 1/3] KVM: MTRR: fix memory type handling if MTRR is completely disabled Alex Williamson
2015-07-23 6:21 ` Paolo Bonzini
2015-07-23 6:29 ` Xiao Guangrong
2015-07-23 7:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B083C6.503@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=bsd@redhat.com \
--cc=edk2-devel@lists.sourceforge.net \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@intel.com \
--cc=jordan.l.justen@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox