[PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[Javier Martinez Canillas]

The exynos-ppmu driver is only a clock consumer and not a clock provider
but its Device Tree binding listed #clock-cells as an optional property.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
index b54bf3a2ff57..aed486692880 100644
--- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
+++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
@@ -17,7 +17,6 @@ Required properties:
 Optional properties:
 - clock-names : the name of clock used by the PPMU, "ppmu"
 - clocks : phandles for clock specified in "clock-names" property
-- #clock-cells: should be 1.
 
 Example1 : PPMU nodes in exynos3250.dtsi are listed below.
 
-- 
2.4.3

Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[Chanwoo Choi]

Hi Javier,

On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
> The exynos-ppmu driver is only a clock consumer and not a clock provider
> but its Device Tree binding listed #clock-cells as an optional property.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
> index b54bf3a2ff57..aed486692880 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
> +++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
> @@ -17,7 +17,6 @@ Required properties:
>  Optional properties:
>  - clock-names : the name of clock used by the PPMU, "ppmu"
>  - clocks : phandles for clock specified in "clock-names" property
> -- #clock-cells: should be 1.
>  
>  Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>  
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

+ Devfreq maintainer (Myungjoo Ham)
I think that this patch will be more appropriate on devfreq git tree
than linux-samsung git tree.

Thanks,
Chanwoo Choi

Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[Javier Martinez Canillas]

Hello Chanwoo,

On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
> Hi Javier,
> 
> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>> The exynos-ppmu driver is only a clock consumer and not a clock
>> provider but its Device Tree binding listed #clock-cells as an
>> optional property.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> 
>> ---
>> 
>> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1
>> - 1 file changed, 1 deletion(-)
>> 
>> diff --git
>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>> index b54bf3a2ff57..aed486692880 100644 ---
>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>> +++
>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>> @@ -17,7 +17,6 @@ Required properties: Optional properties: -
>> clock-names : the name of clock used by the PPMU, "ppmu" - clocks :
>> phandles for clock specified in "clock-names" property --
>> #clock-cells: should be 1.
>> 
>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>> 
>> 
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> 
> + Devfreq maintainer (Myungjoo Ham)

Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
MAINTAINERS file.

> I think that this patch will be more appropriate on devfreq git tree 
> than linux-samsung git tree.
>

Agreed.

> Thanks, Chanwoo Choi --

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[Javier Martinez Canillas]

Hello Myungjoo,

On 07/23/2015 10:30 AM, Javier Martinez Canillas wrote:
> Hello Chanwoo,
> 
> On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
>> Hi Javier,
>>
>> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>>> The exynos-ppmu driver is only a clock consumer and not a clock
>>> provider but its Device Tree binding listed #clock-cells as an
>>> optional property.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> ---
>>>
>>> Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt | 1
>>> - 1 file changed, 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt
>>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>>> index b54bf3a2ff57..aed486692880 100644 ---
>>> a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>>> +++
>>> b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt 
>>> @@ -17,7 +17,6 @@ Required properties: Optional properties: -
>>> clock-names : the name of clock used by the PPMU, "ppmu" - clocks :
>>> phandles for clock specified in "clock-names" property --
>>> #clock-cells: should be 1.
>>>
>>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>>>
>>>
>>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> + Devfreq maintainer (Myungjoo Ham)
> 
> Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
> didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
> sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
> MAINTAINERS file.
> 
>> I think that this patch will be more appropriate on devfreq git tree 
>> than linux-samsung git tree.
>>
> 
> Agreed.
> 

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1337 bytes --]

> Hello Myungjoo,
> 
> On 07/23/2015 10:30 AM, Javier Martinez Canillas wrote:
> > Hello Chanwoo,
> >
> > On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
> >> Hi Javier,
> >>
> >> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
> >>> The exynos-ppmu driver is only a clock consumer and not a clock
> >>> provider but its Device Tree binding listed #clock-cells as an
> >>> optional property.
> >>>
> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >>>
[]
> >>>
> >>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
> >>>
> >>>
> >>
> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> >>
> >> + Devfreq maintainer (Myungjoo Ham)
> >
> > Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
> > didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
> > sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
> > MAINTAINERS file.
> >
> >> I think that this patch will be more appropriate on devfreq git tree
> >> than linux-samsung git tree.
> >>
> >
> > Agreed.
> >
> 
> Any comments about this patch?

Nope. It's applied.


Thanks.



MyungJoo

> 
> 
> 
> Best regards,
> --
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] PM / devfreq: event: Remove incorrect property in exynos-ppmu DT binding

[Javier Martinez Canillas]

Hello MyungJoo,

On 08/03/2015 06:58 AM, MyungJoo Ham wrote:
>> Hello Myungjoo,
>>
>> On 07/23/2015 10:30 AM, Javier Martinez Canillas wrote:
>>> Hello Chanwoo,
>>>
>>> On 07/23/2015 10:19 AM, Chanwoo Choi wrote:
>>>> Hi Javier,
>>>>
>>>> On 07/13/2015 03:58 PM, Javier Martinez Canillas wrote:
>>>>> The exynos-ppmu driver is only a clock consumer and not a clock
>>>>> provider but its Device Tree binding listed #clock-cells as an
>>>>> optional property.
>>>>>
>>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>>>
> []
>>>>>
>>>>> Example1 : PPMU nodes in exynos3250.dtsi are listed below.
>>>>>
>>>>>
>>>>
>>>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>
>>>> + Devfreq maintainer (Myungjoo Ham)
>>>
>>> Thanks for the review and for cc'ing Myungjoo. The get_maintainer.pl script
>>> didn't tell me that so I think Documentation/devicetree/bindings/devfreq/
>>> sub-dir should be added to the DEVICE FREQUENCY (DEVFREQ) entry in the
>>> MAINTAINERS file.
>>>
>>>> I think that this patch will be more appropriate on devfreq git tree
>>>> than linux-samsung git tree.
>>>>
>>>
>>> Agreed.
>>>
>>
>> Any comments about this patch?
> 
> Nope. It's applied.
> 
> 
> Thanks.
> 
>

Great, thanks a lot.
 
> 
> MyungJoo
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America