From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, <xen-devel@lists.xenproject.org>
Cc: <david.vrabel@citrix.com>, <linux-kernel@vger.kernel.org>,
<konrad.wilk@oracle.com>
Subject: Re: [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent
Date: Thu, 23 Jul 2015 10:59:18 +0200 [thread overview]
Message-ID: <55B0ACE6.2080805@citrix.com> (raw)
In-Reply-To: <1437547210-32573-2-git-send-email-bob.liu@oracle.com>
El 22/07/15 a les 8.40, Bob Liu ha escrit:
> We should consider info->feature_persistent when adding indriect page to list
^ indirect
> info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered.
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
Thanks, this looks correct indeed. If we are using persistent grants the
indirect_pages list should always be empty because blkfront has
pre-allocated enough persistent pages to fill all requests on the ring.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Should be backported to stable branches.
Roger.
next prev parent reply other threads:[~2015-07-23 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 6:40 [PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features() Bob Liu
2015-07-22 6:40 ` [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent Bob Liu
2015-07-23 8:59 ` Roger Pau Monné [this message]
2015-07-22 6:40 ` [PATCH v2] xen-blkback: replace work_pending with work_busy in purge_persistent_gnt() Bob Liu
2015-07-23 9:06 ` Roger Pau Monné
2015-07-24 13:10 ` Konrad Rzeszutek Wilk
2015-07-23 9:00 ` [PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features() Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0ACE6.2080805@citrix.com \
--to=roger.pau@citrix.com \
--cc=bob.liu@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox