From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753023AbbGWKsU (ORCPT ); Thu, 23 Jul 2015 06:48:20 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38902 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbbGWKsG (ORCPT ); Thu, 23 Jul 2015 06:48:06 -0400 Message-ID: <55B0C660.8010509@lightnvm.io> Date: Thu, 23 Jul 2015 12:48:00 +0200 From: =?windows-1252?Q?Matias_Bj=F8rling?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christoph Hellwig CC: axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen.Bates@pmcs.com, keith.busch@intel.com Subject: Re: [PATCH v5 4/5] null_blk: LightNVM support References: <1437587464-7964-1-git-send-email-mb@lightnvm.io> <1437587464-7964-5-git-send-email-mb@lightnvm.io> <20150723095351.GB26420@infradead.org> In-Reply-To: <20150723095351.GB26420@infradead.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/23/2015 11:53 AM, Christoph Hellwig wrote: > Any reason you're adding this to null_blk instead of having a separate > null_nvm driver? > Only reason was to not duplicate the I/O submission/completion flow. With the simple code at the moment, it is little to add. However, if someone decides to put backing store, simulation, etc. into it, then it should properly go into another module. Do you want me to move it into a new driver for this patchset?