From: "Noralf Trønnes" <noralf@tronnes.org>
To: Henri Chain <henri.chain@eleves.ec-nantes.fr>,
thomas.petazzoni@free-electrons.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, sudipm.mukherjee@gmail.com
Subject: Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller
Date: Thu, 23 Jul 2015 15:06:09 +0200 [thread overview]
Message-ID: <55B0E6C1.2040702@tronnes.org> (raw)
In-Reply-To: <1436878779-12400-1-git-send-email-henri.chain@eleves.ec-nantes.fr>
Den 14.07.2015 14:59, skrev Henri Chain:
> This is a driver chip for 240x160 4-bit greyscale LCDs.
> It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been
> tested. (It also has a 6800 or 8080-style parallel interface, but I have
> not included support for it.)
>
> Signed-off-by: Henri Chain <henri.chain@eleves.ec-nantes.fr>
> ---
> diff --git a/drivers/staging/fbtft/fb_uc1611.c b/drivers/staging/fbtft/fb_uc1611.c
> +static int init_display(struct fbtft_par *par)
> +{
> + int ret;
> +
> + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
> +
> + /* Set CS active high */
> + par->spi->mode |= SPI_CS_HIGH;
Why is this set here and not in fbtft_device along side SPI_MODE_3?
> +static int set_var(struct fbtft_par *par)
> +{
> + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
> +
> + /* par->info->fix.visual = FB_VISUAL_PSEUDOCOLOR; */
This comment can be removed I guess.
prev parent reply other threads:[~2015-07-23 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 12:59 [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller Henri Chain
2015-07-15 9:36 ` Paul Bolle
2015-07-23 12:14 ` Noralf Trønnes
2015-07-23 13:06 ` Noralf Trønnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0E6C1.2040702@tronnes.org \
--to=noralf@tronnes.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=henri.chain@eleves.ec-nantes.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox