From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbbGWPSk (ORCPT ); Thu, 23 Jul 2015 11:18:40 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56274 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753170AbbGWPSc (ORCPT ); Thu, 23 Jul 2015 11:18:32 -0400 Subject: Re: [PATCH v8 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework To: Srinivas Kandagatla References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403462-4432-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , devicetree@vger.kernel.org, arnd@arndb.de, linux-api@vger.kernel.org, s.hauer@pengutronix.de, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, Rob Herring , pantelis.antoniou@konsulko.com, Mark Brown , linux-arm-msm@vger.kernel.org, mporter@konsulko.com, Maxime Ripard , wxt@rock-chips.com From: Stefan Wahren Message-ID: <55B105B6.7000502@i2se.com> Date: Thu, 23 Jul 2015 17:18:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1437403462-4432-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qDcY62xZ4FufiBXK/1mtjKSCdWkyNbhpjrlinZyZhKmMDwUJO/M 1fbRU21EN6Aj6Sj2g8ITISg6Dm85x124BIJQFYibie1XWxQtKGeMhgafTaNRy4NrSaFGq14 lujWzADtzzQvPR91nltgC4TfBPK46/OuBr9MWTX1eWeu5lzFNgp5SyP7DFk2RO7cUooZTgH iryBjj7701iOeX8YTFDTg== X-UI-Out-Filterresults: notjunk:1;V01:K0:twI1K6J/10k=:6m4mBF1NbCMNMWUBDDpPyr JSBYFPJd5I5KYkpep2hRRxnzYQ26Fv6N1gDBNxBI7ufcPAs7DMOeDBEtBvfEKAM3s7dRk93hn tLYqRM8/D/1TC5k8AP+Jeij00FL5CsD9UIszghMKnJ1rF7YkTptHjhH8L6TDZkM5sDW91QpVQ wYlbCK7+ytL1t/2aRqL8svvzwnxMkV3q2eVSChjMB9sAMOvmXKiwxO/y8zxFXyfLDz9CWDPWA Kvk4rPV6/s/wXnyuTcqfmzV//sg7fsP3JyVanNoNGtlhRGoyAj9uPUU1P74LCEhTMpjpsbN/T LKmD49vRvr1nTHLAhFpSQ+SZ+llNc4lG7mRz0FvAqZXEZatKjYGVy3Jx/xJu5YoOfEzmwSbKf Nfkiap7mqC+BaNNEONY1gXLLK5xyx6WTWcKO+KQPZGdpbHp4FpGPsDbjFdAguDxiS7PSATwnF UinLxoX86m7DLiEY0xy8ys68BDGXisEoT6mJEPDT9RmeKAffWy0/J/eu33W3Bt3iDZFcpEkGX EzkUu8wHjh6c+AOHs9uaPZovOTDDQAfa08is4Q/+ovwY6BEmE03e4T+hyANfDO1AXJmOQKIE+ hd0OQjnmCoqFDuPOi/nHvA4CGk/eEDsscbWnH+1K+BcUT42lMp79WbTNzBDlUpnxTlLSOkplY 5Yxw990k9lX1N2QOe1kgaCcy08IdiEJXjIIcq35/PnMoilA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, Am 20.07.2015 um 16:44 schrieb Srinivas Kandagatla: > From: Maxime Ripard > > Now that we have the nvmem framework, we can consolidate the common > driver code. Move the driver to the framework, and hopefully, it will > fix the sysfs file creation race. > > Signed-off-by: Maxime Ripard > [srinivas.kandagatla: Moved to regmap based EEPROM framework] > Signed-off-by: Srinivas Kandagatla > --- > Documentation/ABI/testing/sysfs-driver-sunxi-sid | 22 --- > .../bindings/misc/allwinner,sunxi-sid.txt | 17 --- > .../bindings/nvmem/allwinner,sunxi-sid.txt | 21 +++ > drivers/misc/eeprom/Kconfig | 13 -- > drivers/misc/eeprom/Makefile | 1 - > drivers/misc/eeprom/sunxi_sid.c | 156 -------------------- > drivers/nvmem/Kconfig | 11 ++ > drivers/nvmem/Makefile | 2 + > drivers/nvmem/sunxi_sid.c | 159 +++++++++++++++++++++ > 9 files changed, 193 insertions(+), 209 deletions(-) > delete mode 100644 Documentation/ABI/testing/sysfs-driver-sunxi-sid > delete mode 100644 Documentation/devicetree/bindings/misc/allwinner,sunxi-sid.txt > create mode 100644 Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt > delete mode 100644 drivers/misc/eeprom/sunxi_sid.c > create mode 100644 drivers/nvmem/sunxi_sid.c > > [...] > diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile > index ff44fe9..4328b93 100644 > --- a/drivers/nvmem/Makefile > +++ b/drivers/nvmem/Makefile > @@ -8,3 +8,5 @@ nvmem_core-y := core.o > # Devices > obj-$(CONFIG_QCOM_QFPROM) += nvmem_qfprom.o > nvmem_qfprom-y := qfprom.o > +obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem_sunxi_sid.o > +nvmem_sunxi_sid-y := sunxi_sid.o is it really necessary to have 2 lines for a single driver? Why not the following line? obj-$(CONFIG_NVMEM_SUNXI_SID) += sunxi_sid.o Regards Stefan