From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbbGWPtU (ORCPT ); Thu, 23 Jul 2015 11:49:20 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38069 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbbGWPtE (ORCPT ); Thu, 23 Jul 2015 11:49:04 -0400 Message-ID: <55B10CE6.2080001@linaro.org> Date: Thu, 23 Jul 2015 16:48:54 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefan Wahren CC: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , devicetree@vger.kernel.org, arnd@arndb.de, linux-api@vger.kernel.org, s.hauer@pengutronix.de, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, Rob Herring , pantelis.antoniou@konsulko.com, Mark Brown , linux-arm-msm@vger.kernel.org, mporter@konsulko.com, Maxime Ripard , wxt@rock-chips.com Subject: Re: [PATCH v8 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403462-4432-1-git-send-email-srinivas.kandagatla@linaro.org> <55B105B6.7000502@i2se.com> In-Reply-To: <55B105B6.7000502@i2se.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/07/15 16:18, Stefan Wahren wrote: > Hi Srinivas, > > Am 20.07.2015 um 16:44 schrieb Srinivas Kandagatla: >> From: Maxime Ripard >> >> Now that we have the nvmem framework, we can consolidate the common >> driver code. Move the driver to the framework, and hopefully, it will >> fix the sysfs file creation race. >> >> Signed-off-by: Maxime Ripard >> [srinivas.kandagatla: Moved to regmap based EEPROM framework] >> Signed-off-by: Srinivas Kandagatla >> --- >> Documentation/ABI/testing/sysfs-driver-sunxi-sid | 22 --- >> .../bindings/misc/allwinner,sunxi-sid.txt | 17 --- >> .../bindings/nvmem/allwinner,sunxi-sid.txt | 21 +++ >> drivers/misc/eeprom/Kconfig | 13 -- >> drivers/misc/eeprom/Makefile | 1 - >> drivers/misc/eeprom/sunxi_sid.c | 156 -------------------- >> drivers/nvmem/Kconfig | 11 ++ >> drivers/nvmem/Makefile | 2 + >> drivers/nvmem/sunxi_sid.c | 159 +++++++++++++++++++++ >> 9 files changed, 193 insertions(+), 209 deletions(-) >> delete mode 100644 Documentation/ABI/testing/sysfs-driver-sunxi-sid >> delete mode 100644 Documentation/devicetree/bindings/misc/allwinner,sunxi-sid.txt >> create mode 100644 Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt >> delete mode 100644 drivers/misc/eeprom/sunxi_sid.c >> create mode 100644 drivers/nvmem/sunxi_sid.c >> >> [...] >> diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile >> index ff44fe9..4328b93 100644 >> --- a/drivers/nvmem/Makefile >> +++ b/drivers/nvmem/Makefile >> @@ -8,3 +8,5 @@ nvmem_core-y := core.o >> # Devices >> obj-$(CONFIG_QCOM_QFPROM) += nvmem_qfprom.o >> nvmem_qfprom-y := qfprom.o >> +obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem_sunxi_sid.o >> +nvmem_sunxi_sid-y := sunxi_sid.o > > is it really necessary to have 2 lines for a single driver? > > Why not the following line? > > obj-$(CONFIG_NVMEM_SUNXI_SID) += sunxi_sid.o > We can do that, but only reason i did it this way is to make the module naming consistent like nvmem_*.ko --srini > Regards > Stefan > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >