From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754083AbbGWPul (ORCPT ); Thu, 23 Jul 2015 11:50:41 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:37342 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754061AbbGWPuc (ORCPT ); Thu, 23 Jul 2015 11:50:32 -0400 Message-ID: <55B10D42.1020803@linaro.org> Date: Thu, 23 Jul 2015 16:50:26 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefan Wahren , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman CC: Rob Herring , Mark Brown , s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org, pantelis.antoniou@konsulko.com, mporter@konsulko.com, wxt@rock-chips.com, Maxime Ripard Subject: Re: [PATCH v8 1/9] nvmem: Add a simple NVMEM framework for nvmem providers References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403392-4136-1-git-send-email-srinivas.kandagatla@linaro.org> <55B107B0.5010706@i2se.com> In-Reply-To: <55B107B0.5010706@i2se.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/07/15 16:26, Stefan Wahren wrote: > Hi Srinivas, > > Am 20.07.2015 um 16:43 schrieb Srinivas Kandagatla: >> This patch adds just providers part of the framework just to enable easy >> review. >> >> Up until now, NVMEM drivers like eeprom were stored in drivers/misc, >> where they all had to duplicate pretty much the same code to register >> a sysfs file, allow in-kernel users to access the content of the devices >> they were driving, etc. >> >> This was also a problem as far as other in-kernel users were involved, >> since the solutions used were pretty much different from on driver to >> another, there was a rather big abstraction leak. >> >> This introduction of this framework aims at solving this. It also >> introduces DT representation for consumer devices to go get the data >> they require (MAC Addresses, SoC/Revision ID, part numbers, and so on) >> from the nvmems. >> >> Having regmap interface to this framework would give much better >> abstraction for nvmems on different buses. >> >> Signed-off-by: Maxime Ripard >> [Maxime Ripard: intial version of eeprom framework] >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/Kconfig | 2 + >> drivers/Makefile | 1 + >> drivers/nvmem/Kconfig | 13 ++ >> drivers/nvmem/Makefile | 6 + >> drivers/nvmem/core.c | 384 +++++++++++++++++++++++++++++++++++++++++ >> include/linux/nvmem-consumer.h | 23 +++ >> include/linux/nvmem-provider.h | 47 +++++ >> 7 files changed, 476 insertions(+) >> create mode 100644 drivers/nvmem/Kconfig >> create mode 100644 drivers/nvmem/Makefile >> create mode 100644 drivers/nvmem/core.c >> create mode 100644 include/linux/nvmem-consumer.h >> create mode 100644 include/linux/nvmem-provider.h > > i've tested this patch with my mxs-ocotp driver [1]. > > So you can add > > Tested-by: Stefan Wahren > Thanks for tested-by, That helps. --srini > Regards > Stefan >