From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbbGXEJC (ORCPT ); Fri, 24 Jul 2015 00:09:02 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:19542 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbGXEI7 (ORCPT ); Fri, 24 Jul 2015 00:08:59 -0400 X-AuditID: cbfec7f5-f794b6d000001495-f8-55b1ba58ea93 Message-id: <55B1BA5A.7020401@samsung.com> Date: Fri, 24 Jul 2015 13:08:58 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Dmitry Torokhov , Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] RTC: switch wakealarm attribute to DEVICE_ATTR_RW References: <1437692468-24788-1-git-send-email-dmitry.torokhov@gmail.com> <1437692468-24788-2-git-send-email-dmitry.torokhov@gmail.com> In-reply-to: <1437692468-24788-2-git-send-email-dmitry.torokhov@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xq7oRuzaGGjQuN7dYcvEqu0XHtcVM FocXvWC0eP3C0OLyrjlsFvs7Oxgd2DyebLrI6LFz1l12jz0TT7J59G1Zxegxfd5PJo/Pm+QC 2KK4bFJSczLLUov07RK4Mo5PO89Y8IK54nDjLMYGxqnMXYycHBICJhKn2p4wQthiEhfurWcD sYUEljJKXPvu1sXIBWR/YZRY0X6QCSTBK6AlsWFlHyuIzSKgKrF04UewZjYBY4nNy5eANYsK REgsX32SEaJeUOLH5HssILaIQLbE+XUbwGqYBdIlZp36DmRzcAgL+EqcmqUCsauTUeJb6xmw XZwCXhKrpzwHq2EW0JO4f1ELolVeYvOat8wTGAVmIdkwC6FqFpKqBYzMqxhFU0uTC4qT0nON 9IoTc4tL89L1kvNzNzFCwvvrDsalx6wOMQpwMCrx8B6YtDFUiDWxrLgy9xCjBAezkgiv5gKg EG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmkJ5akZqemFqQWwWSZODilgIG8cprAyevf fxZecphzMvNgg9md4z8vOihK7ApW227YFcPtPNV/G9PtC/MWRuxbVfzCyj37yHXenzas3D4r ZofnveMrb8v4PqVSZkdquGq9SKfEiiWbPslNmxpzd/fbNWlr5JurLB73TSoIYeY+MCXe5tb2 y6E2x8VezhBbsPpo6XnXdVt+LzyvxFKckWioxVxUnAgAzfJBI2sCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.07.2015 08:01, Dmitry Torokhov wrote: > Instead of using older style DEVICE_ATTR for wakealarm attribute let's > switch to using DEVICE_ATTR_RW that ensures consistent across the kernel > permissions on the attribute. > > Signed-off-by: Dmitry Torokhov > --- > drivers/rtc/rtc-sysfs.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof