From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbbGXEKL (ORCPT ); Fri, 24 Jul 2015 00:10:11 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:18335 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbGXEKI (ORCPT ); Fri, 24 Jul 2015 00:10:08 -0400 X-AuditID: cbfec7f5-f794b6d000001495-42-55b1ba9c81c1 Message-id: <55B1BA9F.7070305@samsung.com> Date: Fri, 24 Jul 2015 13:10:07 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Dmitry Torokhov , Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] RTC: switch to using is_visible() to control sysfs attributes References: <1437692468-24788-1-git-send-email-dmitry.torokhov@gmail.com> <1437692468-24788-3-git-send-email-dmitry.torokhov@gmail.com> In-reply-to: <1437692468-24788-3-git-send-email-dmitry.torokhov@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xy7pzdm0MNTi0WdhiycWr7BYd1xYz WRxe9ILR4vULQ4vLu+awWezv7GB0YPN4sukio8fOWXfZPfZMPMnm0bdlFaPH9Hk/mTw+b5IL YIvisklJzcksSy3St0vgyvjx5RRTwT/Wii1r1zA1MH5n6WLk5JAQMJGY/X0hE4QtJnHh3no2 EFtIYCmjxOOPUl2MXED2F0aJU1OfsIIkeAW0JI5MuwpWxCKgKrH86mJGEJtNwFhi8/IlYHFR gQiJ5atPMkLUC0r8mHwPbJmIQLbE+XUbwGqYBdIlZp36DmYLC0RLfHk6hQlicSejROt/HxCb U8BL4v7FT0C9HED1ekC2FkSrvMTmNW+ZJzAKzEKyYRZC1SwkVQsYmVcxiqaWJhcUJ6XnGukV J+YWl+al6yXn525ihIT31x2MS49ZHWIU4GBU4uE9MGljqBBrYllxZe4hRgkOZiURXs0FQCHe lMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwbmCpPKhmx1Bm rFKgVqOxonrpG9GTJw08OrdsWyPQm5kvKvBu4bHiSc4pyvLqDafZdmjm2R1iaRCss/km6BPe ckp54n1r5viTV5ZtfbW7vMYi55713TwthYeqU7c4Pjmu37Lqw4vlvRx//izuDgw+4NF/RUkg xXfLk2rtwGfFPvXnJv9daOWrxFKckWioxVxUnAgAoSy3l2sCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.07.2015 08:01, Dmitry Torokhov wrote: > Instead of creating wakealarm attribute manually, after the device has been > registered, let's rely on facilities provided by the attribute groups to > control which attributes are visible and which are not. This allows to to > create all needed attributes at once, at the same time that we register RTC > class device. > > Signed-off-by: Dmitry Torokhov > --- > drivers/rtc/class.c | 4 +--- > drivers/rtc/rtc-core.h | 19 +++------------- > drivers/rtc/rtc-sysfs.c | 59 +++++++++++++++++++++++++------------------------ > 3 files changed, 34 insertions(+), 48 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof