From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbbGXIWM (ORCPT ); Fri, 24 Jul 2015 04:22:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:55086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbbGXIWI (ORCPT ); Fri, 24 Jul 2015 04:22:08 -0400 Subject: Re: [PATCH] Input: LEDs - skip unnamed LEDs To: Dmitry Torokhov , Pavel Machek , Jiri Kosina References: <20150722220202.GG14875@dtor-ws> Cc: Samuel Thibault , =?UTF-8?Q?Pali_Roh=c3=a1r?= , linux-input@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman , linux-kernel@vger.kernel.org From: Vlastimil Babka Message-ID: <55B1F5AC.3080702@suse.cz> Date: Fri, 24 Jul 2015 10:22:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150722220202.GG14875@dtor-ws> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/23/2015 12:02 AM, Dmitry Torokhov wrote: > Devices may declare more LEDs than what is known to input-leds > (HID does this for some devices). Instead of showing ugly warnings > on connect and, even worse, oopsing on disconnect, let's simply > ignore LEDs that are not known to us. > > Reported-by: Vlastimil Babka No more warnings and oopses, so: Reported-and-tested-by: Vlastimil Babka FTR, it now looks like this: gusiac:/sys/bus/hid/devices/0003:046D:C50E.0004/input/input15 # ls -1 | grep input15 input15::charging input15::mail input15::misc All three have max_brightness of 1, but echo 1 > brightness does nothing. Clearly the leds are indeed autonomous only and the mouse shouldn't even report them. Thanks, Vlastimil