From: Alex Smith <alex.smith@imgtec.com>
To: Vinod Koul <vinod.koul@intel.com>, Julia Lawall <julia.lawall@lip6.fr>
Cc: <Zubair.Kakakhel@imgtec.com>, <dmaengine@vger.kernel.org>,
"Vaishali Thakkar" <vthakkar1994@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: question about drivers/dma/dma-jz4780.c
Date: Fri, 24 Jul 2015 09:28:19 +0100 [thread overview]
Message-ID: <55B1F723.3010702@imgtec.com> (raw)
In-Reply-To: <20150724063019.GP29916@localhost>
On 24/07/2015 07:30, Vinod Koul wrote:
> On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote:
>>> Yes for dmaengine drivers I do ask this question which typically ends up in
>>> driver invoking devm_irq_free() in driver's remove callback
>>>
>>> IMHO don't think devm irq calls are very useful, they do make stuff
>>> complicate
>>
>> Would it be better then to just go back to request_irq (or whatever is
>> appropriate in this case). It would seem that the devm property can never
>> be relied on, so there is no point to use it.
>
> Yes I do think that is right way in this case
>
Hmm, OK, I will drop the patch I submitted removing the explicit
devm_free_irq() call and send a new one which stops using the devm IRQ
functions, and kills the tasklets.
Thanks,
Alex
prev parent reply other threads:[~2015-07-24 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 9:08 question about drivers/dma/dma-jz4780.c Julia Lawall
2015-07-20 8:18 ` Alex Smith
2015-07-20 8:28 ` Julia Lawall
2015-07-21 4:15 ` Vinod Koul
2015-07-22 14:26 ` Alex Smith
2015-07-23 17:21 ` Vinod Koul
2015-07-23 17:24 ` Julia Lawall
2015-07-24 5:42 ` Vinod Koul
2015-07-24 5:51 ` Julia Lawall
2015-07-24 6:30 ` Vinod Koul
2015-07-24 6:49 ` Julia Lawall
2015-07-24 8:28 ` Alex Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B1F723.3010702@imgtec.com \
--to=alex.smith@imgtec.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dmaengine@vger.kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox