public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of/irq: introduce of_has_named_irqs helper
Date: Fri, 24 Jul 2015 12:35:16 -0700	[thread overview]
Message-ID: <55B29374.7040201@gmail.com> (raw)
In-Reply-To: <20150724182655.GA22007@dtor-ws>

On 24/07/15 11:26, Dmitry Torokhov wrote:
> Sometimes drivers might wish to transition from index-based to named
> interrupt descriptions. To aid in decision-making when parsing device
> tree data let's provide a helper that will indicate the scheme that is
> being used.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

[snip]

> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 3cf7a01..e02c43e 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -384,6 +384,19 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
>  EXPORT_SYMBOL_GPL(of_irq_to_resource);
>  
>  /**
> + * of_has_named_irq - Check if given node contains named interrupts
> + * @dev: pointer to device tree node
> + *
> + * Returns %true if node contains non-empty "interrupt-names" property.
> + */
> +bool of_has_named_irqs(struct device_node *dev)
> +{
> +	struct property *prop = of_find_property(dev, "interrupt-names", NULL);
> +
> +	return prop && prop->value;
> +}

Missing EXPORT_SYMBOL_GPL() here?
-- 
Florian

      parent reply	other threads:[~2015-07-24 19:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 18:26 [PATCH] of/irq: introduce of_has_named_irqs helper Dmitry Torokhov
2015-07-24 19:14 ` Rob Herring
2015-07-24 19:26   ` Dmitry Torokhov
2015-07-24 20:16     ` Dmitry Torokhov
2015-07-28 13:23       ` Vignesh R
2015-07-28 17:23         ` Dmitry Torokhov
2015-07-28 17:46           ` R, Vignesh
2015-07-28 18:07             ` Dmitry Torokhov
2015-07-29  4:33               ` Vignesh R
2015-07-24 20:59     ` Rob Herring
2015-07-24 21:22       ` Dmitry Torokhov
2015-07-24 19:35 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B29374.7040201@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox