Re: [PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi_domain field

Bjorn Helgaas
2015-07-23T13:06:52Z

On Thu, Jul 23, 2015 at 10:26:23AM +0100, Marc Zyngier wrote:
> In order to be able to populate the device msi_domain field,
> add the necessary hooks to propagate the host bridge msi_domain
> across secondary busses to devices.
>
> So far, nobody populates the initial msi_domain.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> +static void pci_set_msi_domain(struct pci_dev *dev)
> +{
> + /*
> + * If no domain has been set through the pcibios callback,
> + * inherit the default from the bus device.

Nit: there isn't a pcibios callback anymore.

> + */
> + if (!dev_get_msi_domain(&dev->dev))
> + dev_set_msi_domain(&dev->dev,
> + dev_get_msi_domain(&dev->bus->dev));
> +}