From: Florian Fainelli <f.fainelli@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>, tj@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
gregory.0xf0@gmail.com
Subject: Re: [PATCH 4.2] ata: ahci_brcmstb: Fix warnings with CONFIG_PM_SLEEP=n
Date: Mon, 27 Jul 2015 12:54:07 -0700 [thread overview]
Message-ID: <55B68C5F.5050301@gmail.com> (raw)
In-Reply-To: <20150714220629.GA21362@localhost>
On 14/07/15 15:06, Brian Norris wrote:
> On Tue, Jul 14, 2015 at 01:03:33PM -0700, Florian Fainelli wrote:
>> When CONFIG_PM_SLEEP is disabled, brcm_ahci_{suspend,resume} are not
>> used, which causes such a build warning to occur:
>>
>> CC drivers/ata/ahci_brcmstb.o
>> drivers/ata/ahci_brcmstb.c:212:12: warning: 'brcm_ahci_suspend' defined
>> but not used [-Wunused-function]
>> static int brcm_ahci_suspend(struct device *dev)
>> ^
>> drivers/ata/ahci_brcmstb.c:224:12: warning: 'brcm_ahci_resume' defined
>> but not used [-Wunused-function]
>> static int brcm_ahci_resume(struct device *dev)
>> ^
>> LD drivers/ata/built-in.o
>>
>> Fixes: 766a2d979632 ("ata: add Broadcom AHCI SATA3 driver for STB chips")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> Tejun, this is a new driver that got merged during 4.2, could you queue
>> this up for an upcoming 4.2-rcX pull request?
>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
>
Tejun, I am not seeing this change queued in your for-4.2-fixes branch
did you need me to do anything?
--
Florian
next prev parent reply other threads:[~2015-07-27 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 20:03 [PATCH 4.2] ata: ahci_brcmstb: Fix warnings with CONFIG_PM_SLEEP=n Florian Fainelli
2015-07-14 22:06 ` Brian Norris
2015-07-27 19:54 ` Florian Fainelli [this message]
2015-07-28 18:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B68C5F.5050301@gmail.com \
--to=f.fainelli@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).