From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755360AbbG1HpA (ORCPT ); Tue, 28 Jul 2015 03:45:00 -0400 Received: from mail-bn1on0060.outbound.protection.outlook.com ([157.56.110.60]:59232 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752325AbbG1Ho5 (ORCPT ); Tue, 28 Jul 2015 03:44:57 -0400 Authentication-Results: spf=pass (sender IP is 62.221.5.235) smtp.mailfrom=xilinx.com; atmel.com; dkim=none (message not signed) header.d=none; Subject: Re: [RFCv2 2/3] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller. To: Nicolas Ferre , Moritz Fischer , Michal Simek References: <1437783682-13632-1-git-send-email-moritz.fischer@ettus.com> <1437783682-13632-3-git-send-email-moritz.fischer@ettus.com> <55B5D62D.4010407@monstr.eu> <55B72857.3020108@atmel.com> CC: , , , , , , Michal Simek , , , linux-arm-kernel , Kumar Gala , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= From: Michal Simek Message-ID: <55B732E6.7080901@xilinx.com> Date: Tue, 28 Jul 2015 09:44:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55B72857.3020108@atmel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21708.003 X-TM-AS-User-Approved-Sender: Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD035;1:ztef5Psz4Abv+peOdpzjPtpB8LY2cb7rJhUlncBigP3QYjDtqOnPu+0ZiPq9w2Hu5uSsaWN7q6jg18tiJLcHn4QEbePASxL3Vcr5DSfVpEXu17+KhdH5yWJvToubLLUrhVb0Pc9++TiXOXNGyG13Q+5FVHaPXxZzkbVI6ypGyIZrD1BaEVHmWORlMUGI9oiJp9OhCMexupxG3QAZHfSLrtBmIgorjrW6Ki6ERmX6YZmegcKTMZYntkSLGKnGlFylpqsQW4ZmpFdtR9fQQ4HBtg== X-Forefront-Antispam-Report: CIP:62.221.5.235;CTRY:GB;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(377454003)(199003)(164054003)(51444003)(189002)(24454002)(23676002)(80316001)(87936001)(83506001)(86362001)(93886004)(19580395003)(54356999)(46102003)(33656002)(76176999)(19580405001)(50466002)(47776003)(50986999)(59896002)(6806004)(106466001)(5001960100002)(2950100001)(65816999)(62966003)(77156002)(36756003)(107886002)(65806001)(92566002)(77096005)(4001350100001)(36386004)(64126003)(189998001)(107986001)(42866002)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB055;H:xir-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB055;2:LAUY9lVUGseW3lgPw33JxND1XurRvW3qBSInlK63tZ4DrQSsOf2DzaiibKrrXCJaZcxxxSlOmupXtF6O01lkc/UggGq3FwJqJJ7ehNGl3ahdFia78oNMLQ+VZnB0FovgUzbx6ZIUAb8856cBCdG8urHs4oVUWNxkjqhfkoBwGfg=;3:VOBnL7maXDXGYEdD7cbPwo8+kt/jwajep21fsoUnVCtGTri1OND3yb2MvLwYZvSjzK4vVENjiGk2OF9keAoedwXF0Sfh/b0pDd3Yzvpb+iF6Fw8/ltg2ogP21Lo71NWaMJ13JuknEJ8v5KicFqrz7w890frHEqcWNaHNQZlS/Yvm1zQlagnWqcepwJw+GiqzMo1ytUb5U2I+v8Sh4Td7r4erO/K77ljgG4f/qucSSRQ=;25:q3glDlXTFTFYGUNgx3eG9JqYxmjghfpUysbZ3Yo11KrwgntPuO65dp1UzeOkesRiB9wRD2qtEz+dwzLqwfmFxSKFKQWNXHrNreYR5yBEqdloRWFQR+4EFGWhJW/FMBRCVglF162vC+1P/tL6tlOFc1hSXUq1dcaVrlUeWDlg+KQik4IaFjvMz+YAYPUHe2kzabPrehlycEsozim47nuRlleIjymiMKW2xrNDaQIsV8rnVztCo+eQ8LdOCUa5jFvV X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB055; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB055;20:xA293pGSAOm7SFkaxNUFJc6LVV0HMA1vw6GWDs7SxVQRV40DHwPERs63BveSbg2yIDo8oRodHt/OO5flv1BG5hVVWDCKwEo5KI4L9ZaQP1xUx55RDY0zP/f3D8hRZog59VkmUsaGRV1b4Pba9PfzsQcgwm8B3XaZnG0gpKZAkyhEEGvo+PfdvYFaPCT1MxOm8oN8VB7qpbIvXl70KEv1LfKvqiz4ZT6BecAD1Yz8PxxBMt1S+llukWBib4jHiDcrY6lLH2ErqtEBHqkzCBRmdDfwpARBti1TBsWhbt80/de9pYJHAy8+kBThnx07QKrKaDPE6QXM1xRftfBZgrXwgSiV4q9vpdzcbcpV9Vc75jxjsH22JUgPHT9e0IPUF8glCdAHRH4kCAJ1fwqFvdIWyJd2i9nSwc7yG8GnY1skAKXiQ+Vk4eGAIXeevW2Fffcvl94h+kg0u/AHz52Bpkuifs7+CVUl2BYew4IlyHPQxis++bQfDGOgurwoSOqC5Sa/;4:ZcYxSTa9Cb1j/aJYyMjckkFd0Brd93dv5GdJe9pyVAkQtp/5Lsyg3/ZC4JllX73nuFK+JFFU2Z9WYjIJDzSW21nwLznU8yPsAaOsau2Ak0F92+o4fweuMuWyMQsAPg4o84yhhji9S+NBXwROz8FUO1lsJj0gktQkl9I8ezD5+DO7of0xKohhx+DLEbQvigZIEn5rXnAY3BeCQok8l7+tSlRyCv8NFDbXEhWtkfDURmgzLM25fyQyTSxYBX/LuvXxdMeIDD0NBbgm43Md58zFsfsroxOHb1ZDGnEsr5OMMWk= BN1BFFO11HUB055: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1BFFO11HUB055;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB055; X-Forefront-PRVS: 06515DA04B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFCRkZPMTFIVUIwNTU7MjM6OVB2bmVZa1VxUVMwN2FYMjRsb1lyM2JJ?= =?utf-8?B?a2xPVjExNUZsOEtwcjZ2NHRyaCtMa2QyN0U5MUVoSjhyRzBnRm04bmVkbmdk?= =?utf-8?B?RmdkOGd1RFdxYTVyZHI0d0NleVJCRlNCdjk2eWs5eE54YmZRT2RXTHVMM3lI?= =?utf-8?B?dm5ESnRySjAvMlR4MmtwVHBNUnNWenJueFhsYmVlaG4yZER2NEY2ejhCUmRq?= =?utf-8?B?SXY5ZlNjZlR2U0ZyWEFTWmZjQUJqRUdndFQrODNEcGFVMS9TYUhKcGRMV2JB?= =?utf-8?B?aXRXcVIvTVRnOFBMZWQ4MmNSMFhRbXNrVmx3Lzl5OHNhZ04vd2RmRkR0QTBu?= =?utf-8?B?UzlZTlNVeXZQN0FqUmROOG8rYSthNXczWmxZZ3RySk9vQWYwMnJZS2JhV3Ba?= =?utf-8?B?Ujc5Q1Q1WkdZT1NMakJnd2pyUXJkaXZjQjl6S1NOcjBYbHJYY0lBanJRZ3FH?= =?utf-8?B?TThwNnBsRFJkeTIrYUIvM1UxNzZvYUY5NmdOdlVCVmtWUDVYRExXanp1a000?= =?utf-8?B?VlZqSUptc3ZsTTJ3KzFiQzBydGR2MnJNSTRQM21sajBpWXBpOG9TOHl2bVpV?= =?utf-8?B?MHQyaXB6UHlwMG1QWXZtcHNKU2ltRWJYTEhTRE9PQncvdk1tVVlIdmkrNEdu?= =?utf-8?B?NDhneFZ5WXVmczluMGpyT0VPdmd2MURyWHRmYnRzdGxrUkp3VmI5S3ZzNXJ5?= =?utf-8?B?YXlLZUZubnZjSmlyVVIrY0RPNVhFbWQwZFlXS0JGczl1dUVvWUJTK0dtbUFB?= =?utf-8?B?TFM0bHZIZk9ybklnTFBpNEVHTDZDRWNEcysrUEZTeWdpMHJPYktYcjlWVmF0?= =?utf-8?B?d3BzanhCbjZaMllUWFVKZlY5eWlQQVB2Q3hFSktKL2pQb0tYdXZhMHJGVzdt?= =?utf-8?B?RmF6N29FSGJ6SEIzMHN6dkp0V0tQaDU2V01DZ3c4Q1BoQ1d3Tjl4WkpZSzNS?= =?utf-8?B?Z0lWeHdRdjcyQ0g1ZzRITDRtWXFXMXV6RWw2dWFqQ095Y1hNOW9LQ2V3Y1Ur?= =?utf-8?B?cHdKTmgyMEJFMkpyMm45cXRLSTV6MktBYjd4MWhKWmJhRmxpUnBDM2JZMyt3?= =?utf-8?B?WGNMc1N1dHlNRnZZZEhvTnBldENTbHZ1a016bnB2eWI5cWU1Z2gzN3Jhc1Fx?= =?utf-8?B?ZXIwbXNMa0ljM1RyZEM2Mk9sQVpoL1hlanpWTzJ6Y0NUbmMvZjdGREw1eTBS?= =?utf-8?B?MHpEbFhDNlI1aWY2NG5Vc25mNGNzSVpWSyt0Z3lqS0gxcDl1K3NrTFNmNUc0?= =?utf-8?B?anZPbEVVMzNWTWRlZFFWLytrUitCZ0dXeTAxTmptc29mR29tS1N2eUtTL3BW?= =?utf-8?B?R1lWSkxWbUVXZkU1ZVRsdkRmSlpLMU81Rm53OFBYMzNsYkxxdVFIeVhXRjd2?= =?utf-8?B?d3ZLMTQ1Q2daSWEyay9EakMvL2dDbzdmVmVUVTlHWGNpUHFUS0xOQTQ3UGJO?= =?utf-8?B?S0orb0tPOS8rSEljUU1uQ1RlTXZZa1NsYm5PYWRDbUxrRmRFK3lDdzE1M0Jq?= =?utf-8?B?Q1EvdUprSkI3NXRBaXVsbmlRS1A5eWtOb2ttcGNmaXBwUGh6QWRzRlFZcUpl?= =?utf-8?B?ZkNFZmlRU0NRdWFSYWJJd05tOG1EbG1pUk9BQktSSjlFOVlRdXB1UXFyUzVR?= =?utf-8?Q?k=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB055;5:IHeQdqEmHGIDcHEwa1+/mtE8voXqasu3yoIh9ytBPQ4i1Gy6qEoXTdX3yFdf40Tfxa1Z6QOW+RTpU+tRp48m45N3QZd64WFM072RSlGMvAi/7tanhMBDXANpGEoWO8e1Y5322AI928Q0LOhDWBlqOQ==;24:GqlGgRUbG/PZTHYdpqsizpx8OlOCACXfUdalTcFHqK375O6qv/1gJx710miXz0q872im1jYQxCYm56PWc6s3bxwccqz6ZSoVALJArVJrn6c= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2015 07:44:55.3929 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[62.221.5.235];Helo=[xir-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB055 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/28/2015 08:59 AM, Nicolas Ferre wrote: > Le 28/07/2015 07:03, Moritz Fischer a écrit : >> Hi Michal, >> >> I agree we need to be careful with changing the bindings. >> >> On Sun, Jul 26, 2015 at 11:56 PM, Michal Simek wrote: >>> Hi Moritz, >>> >>> On 07/25/2015 02:21 AM, Moritz Fischer wrote: >>>> Signed-off-by: Moritz Fischer >>>> --- >>>> arch/arm/boot/dts/zynq-7000.dtsi | 43 ++++++++++++- >>> >>> This patch is nice in general but every change in binding should be >>> discussed separately. There is also necessary to wire them up in the >>> driver to do action. That's why I think that will be the best just to >>> add the code to slcr and keep others untouched. >> >> Ok, just to clarify: You'd suggest to just add the rstc as child node >> to the slcr, >> and leave the other nodes untouched? >> >>> >>> For example MACB/GEM is one example. Adding names to this node and >>> extending driver to work properly with reset means that all others MACB >>> users will be affected. Definitely this patch should be ACKed by Nicolas. > > Actually, I don't know why a reset property should be added to the macb > driver... I expect resetting IP core can solve something. But as I said it is questionable if IP should be reset when driver is probed. Definitely on Zynq there is a support for it. I am not aware about any problem which requires IP to be reset. Thanks, Michal