From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: dts: rockchip: Add SPDIF transceiver for RK3188
Date: Tue, 28 Jul 2015 16:48:57 +0300 [thread overview]
Message-ID: <55B78849.6060706@cogentembedded.com> (raw)
In-Reply-To: <1438085011-16577-4-git-send-email-sjoerd.simons@collabora.co.uk>
Hello.
On 7/28/2015 3:03 PM, Sjoerd Simons wrote:
> Add the SPDIF transceiver controller and pin for RK3188
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
> arch/arm/boot/dts/rk3188.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi
> index 0f23aed..43e9bdf 100644
> --- a/arch/arm/boot/dts/rk3188.dtsi
> +++ b/arch/arm/boot/dts/rk3188.dtsi
> @@ -121,6 +121,22 @@
> status = "disabled";
> };
>
> + spdif: spdif@0x1011e000 {
Please drop "0x". And I'd call the node "sound@..." to match the ePAPR
standard.
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-07-28 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 12:03 [PATCH 0/4] Add SPDIF support for rockchip Sjoerd Simons
2015-07-28 12:03 ` [PATCH 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings Sjoerd Simons
2015-07-28 12:03 ` [PATCH 2/4] ASoc: rockchip: Add rockchip SPDIF transceiver driver Sjoerd Simons
2015-07-28 14:28 ` Heiko Stübner
2015-07-28 15:13 ` Sjoerd Simons
2015-07-29 8:51 ` Paul Bolle
2015-08-07 13:13 ` Mark Brown
2015-07-28 12:03 ` [PATCH 3/4] ARM: dts: rockchip: Add SPDIF transceiver for RK3188 Sjoerd Simons
2015-07-28 13:48 ` Sergei Shtylyov [this message]
2015-07-28 14:20 ` Heiko Stübner
2015-07-28 12:03 ` [PATCH 4/4] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock Sjoerd Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B78849.6060706@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox