From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@gmail.com>
Subject: Re: [RFC/BUG] perf tools: static build fails
Date: Wed, 29 Jul 2015 00:14:41 +0300 [thread overview]
Message-ID: <55B7F0C1.7050507@intel.com> (raw)
In-Reply-To: <20150728161139.GE575@kernel.org>
On 28/07/2015 7:11 p.m., Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 28, 2015 at 05:13:47PM +0200, Jiri Olsa escreveu:
>> hi,
>> it's failing on perf-read-vdso32 tool..
>> attached patch fixes that for me
>
> To build it statically:
>
> make -C tools/perf O=/tmp/build/perf LDFLAGS=-static install-bin
>
> Adrian, I wonder if building just these utilities non-statically when we
> ask for a static build of the main tool is ok, is it?
Not really.
Static build works for me, including building perf-read-vdso32 statically,
so I am not sure what the problem is?
>
> - Arnaldo
>
>
>
>> jirka
>>
>>
>> ---
>> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
>> index 4b58daeff881..a72f790f05e8 100644
>> --- a/tools/perf/Makefile.perf
>> +++ b/tools/perf/Makefile.perf
>> @@ -370,12 +370,12 @@ $(OUTPUT)perf-%: %.o $(PERFLIBS)
>>
>> ifndef NO_PERF_READ_VDSO32
>> $(OUTPUT)perf-read-vdso32: perf-read-vdso.c util/find-vdso-map.c
>> - $(QUIET_CC)$(CC) -m32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
>> + $(QUIET_CC)$(CC) -m32 $(filter-out -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
>> endif
>>
>> ifndef NO_PERF_READ_VDSOX32
>> $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-vdso-map.c
>> - $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
>> + $(QUIET_CC)$(CC) -mx32 $(filter-out -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
>> endif
>>
>> $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
next prev parent reply other threads:[~2015-07-28 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 15:13 [RFC/BUG] perf tools: static build fails Jiri Olsa
2015-07-28 16:11 ` Arnaldo Carvalho de Melo
2015-07-28 21:14 ` Adrian Hunter [this message]
2015-07-28 21:21 ` Arnaldo Carvalho de Melo
2015-07-29 8:30 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7F0C1.7050507@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).