Re: [PATCH v5 2/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/status

Michal Hocko
2015-08-20T11:00:10Z

On Thu 20-08-15 08:26:27, Naoya Horiguchi wrote:
> Currently there's no easy way to get per-process usage of hugetlb pages,

Is this really the case after your previous patch? You have both
HugetlbPages and KernelPageSize which should be sufficient no?

Reading a single file is, of course, easier but is it really worth the
additional code? I haven't really looked at the patch so I might be
missing something but what would be an advantage over reading
/proc/<pid>/smaps and extracting the information from there?

[...]
> Documentation/filesystems/proc.txt | 3 +++
> fs/hugetlbfs/inode.c | 12 ++++++++++
> fs/proc/task_mmu.c | 1 +
> include/linux/hugetlb.h | 36 +++++++++++++++++++++++++++++
> include/linux/mm_types.h | 7 ++++++
> kernel/fork.c | 3 +++
> mm/hugetlb.c | 46 ++++++++++++++++++++++++++++++++++++++
> mm/mmap.c | 1 +
> mm/rmap.c | 4 +++-
> 9 files changed, 112 insertions(+), 1 deletion(-)
[...]
--
Michal Hocko
SUSE Labs