Re: Bug: shared usb dt document is incorrect

Peter Chen
2015-07-29T01:37:03Z

On Tue, Jul 28, 2015 at 06:06:30PM -0700, Tim Bird wrote:
> Antoine and Rob,
>
> I was just doing some testing with USB on a Qualcomm SoC.
>
> I followed the instructions in the binding document:
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>
> which has a compatible for "qcom,ci-hdrc", and is, in general,
> for chipidea-based USB controllers.
>
> It says in the document that the property usb-phy is deprecated, and to
> use phys and phy-names instead. However, the Qualcomm
> driver for this still uses usb-phy. That driver is in:
> drivers/usb/chipidea/ci_hdrc_msm.c
>
> I'm guessing I should update the Qualcomm driver to use
> phys and phy-names, but wanted to check with you-all to
> verify that this is the preferred method of getting
> phys by phandle now. It's either change the driver
> or make an exception in the binding document, I believe.
>
> I presume I should be changing devm_usb_get_phy_by_phandle()
> to of_phy_get(), but let me know if there's more to it than that.
>
> In case I change the driver, do I then update the binding doc
> to remove the information about the deprecated property, or not?
>
> Please advise.

In my opinion, you can just keep both driver and binding doc unchanging
until the generic PHY supports all things the current USB PHY supports,
eg, .notify_disconnect is used in your PHY driver, but it is not
supported in generic PHY framework.

--

Best Regards,
Peter Chen