public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ray Jui <rjui@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Olof Johansson <olof@lixom.net>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Hauke Mehrtens <hauke@hauke-m.de>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <arm@kernel.org>,
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
Date: Wed, 29 Jul 2015 09:17:02 -0700	[thread overview]
Message-ID: <55B8FC7E.50900@broadcom.com> (raw)
In-Reply-To: <33449873.RA3z6vhrMA@wuerfel>



On 7/29/2015 7:30 AM, Arnd Bergmann wrote:
> On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
>>  config PCIE_IPROC_BCMA
>>         bool "Broadcom iProc PCIe BCMA bus driver"
>> -       depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>> +       depends on ARCH_BCM_IPROC && ARM
>>         select PCIE_IPROC
>>         select BCMA
>>         select PCI_DOMAINS
>>
> 
> How about this:
> 
> 	depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
> 
> That would leave the compile test present for non-iproc
> ARM platforms while preventing ARM64 and MIPS builds with
> ARCH_BCM_IPROC set.
> 
> 	Arnd
> 

That is indeed better. Broader compile test coverage is always good.
I'll submit another patch with the above suggested change.

Thanks,

Ray

      reply	other threads:[~2015-07-29 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 18:52 [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig Ray Jui
2015-07-29 14:30 ` Arnd Bergmann
2015-07-29 16:17   ` Ray Jui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B8FC7E.50900@broadcom.com \
    --to=rjui@broadcom.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=hauke@hauke-m.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox