From: Paolo Bonzini <pbonzini@redhat.com>
To: Steve Rutherford <srutherford@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
alex.williamson@redhat.com, yang.z.zhang@intel.com,
srutherford@intel.com
Subject: Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU
Date: Thu, 30 Jul 2015 09:19:51 +0200 [thread overview]
Message-ID: <55B9D017.2090107@redhat.com> (raw)
In-Reply-To: <20150730035543.GE15229@google.com>
On 30/07/2015 05:55, Steve Rutherford wrote:
> > static void vcpu_scan_ioapic(struct kvm_vcpu *vcpu)
> > {
> > - u64 eoi_exit_bitmap[4];
> > -
> > if (!kvm_apic_hw_enabled(vcpu->arch.apic))
> > return;
> >
> > - memset(eoi_exit_bitmap, 0, 32);
> > + memset(vcpu->arch.eoi_exit_bitmap, 0, 256 / 8);
> >
> > - kvm_ioapic_scan_entry(vcpu, eoi_exit_bitmap);
> > - kvm_x86_ops->load_eoi_exitmap(vcpu, eoi_exit_bitmap);
> > + kvm_ioapic_scan_entry(vcpu, vcpu->arch.eoi_exit_bitmap);
> Nit: Does scan entry still need to carry around the pointer to the bitmap?
IIRC I was copying what you did in your patch, but I also think it's
better this way. The IOAPIC has no business in the vcpu structure's
fields; it only needs it in order to pass vcpu to kvm_apic_match_dest.
Paolo
next prev parent reply other threads:[~2015-07-30 7:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 13:37 [PATCH 0/2] KVM: x86: limit interactions between IOAPIC and LAPIC Paolo Bonzini
2015-07-29 13:37 ` [PATCH 1/2] KVM: x86: set TMR when the interrupt is accepted Paolo Bonzini
2015-07-30 3:39 ` Steve Rutherford
2015-07-30 23:26 ` Zhang, Yang Z
2015-07-31 2:49 ` Steve Rutherford
2015-07-31 7:57 ` Paolo Bonzini
2015-08-03 2:44 ` Zhang, Yang Z
2015-07-31 8:01 ` Paolo Bonzini
2015-08-03 2:37 ` Zhang, Yang Z
2015-08-03 8:10 ` Paolo Bonzini
2015-08-03 10:23 ` Zhang, Yang Z
2015-08-03 10:55 ` Paolo Bonzini
2015-08-04 0:46 ` Zhang, Yang Z
2015-08-04 6:59 ` Paolo Bonzini
2015-08-04 7:21 ` Zhang, Yang Z
2015-08-13 6:35 ` Zhang, Yang Z
2015-08-13 7:31 ` Paolo Bonzini
2015-09-02 22:38 ` Steve Rutherford
2015-09-03 5:18 ` Nakajima, Jun
2015-09-03 7:38 ` Paolo Bonzini
2015-07-29 13:37 ` [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU Paolo Bonzini
2015-07-30 3:55 ` Steve Rutherford
2015-07-30 7:19 ` Paolo Bonzini [this message]
2015-07-29 20:00 ` [PATCH 0/2] KVM: x86: limit interactions between IOAPIC and LAPIC Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B9D017.2090107@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srutherford@google.com \
--cc=srutherford@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox