From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755207AbbG3JMR (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Jul 2015 05:12:17 -0400
Received: from foss.arm.com ([217.140.101.70]:39586 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755111AbbG3JMP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Jul 2015 05:12:15 -0400
Message-ID: <55B9EA6B.70403@arm.com>
Date: Thu, 30 Jul 2015 10:12:11 +0100
From: Sudeep Holla <sudeep.holla@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Stephen Boyd <sboyd@codeaurora.org>
CC: Sudeep Holla <sudeep.holla@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        Punit Agrawal <Punit.Agrawal@arm.com>,
        "Jon Medhurst (Tixy)" <tixy@linaro.org>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Kevin Hilman <khilman@kernel.org>,
        Mike Turquette <mturquette@baylibre.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v5 3/8] clk: add support for clocks provided by SCP(System
 Control Processor)
References: <1437649828-14540-1-git-send-email-sudeep.holla@arm.com> <1437649828-14540-4-git-send-email-sudeep.holla@arm.com> <55B90F5B.9070100@codeaurora.org>
In-Reply-To: <55B90F5B.9070100@codeaurora.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 29/07/15 18:37, Stephen Boyd wrote:
> On 07/23/2015 04:10 AM, Sudeep Holla wrote:
>> On some ARM based systems, a separate Cortex-M based System Control
>> Processor(SCP) provides the overall power, clock, reset and system
>> control. System Control and Power Interface(SCPI) Message Protocol
>> is defined for the communication between the Application Cores(AP)
>> and the SCP.
>>
>> This patch adds support for the clocks provided by SCP using SCPI
>> protocol.
>>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: Mike Turquette <mturquette@baylibre.com>
>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Jon Medhurst (Tixy) <tixy@linaro.org>
>> Cc: linux-clk@vger.kernel.org
>
> Looks good to me, modulo one comment.
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>

Thanks, I assume you are fine if this gets merged via arm-soc

>> +
>> +static const struct of_device_id scpi_clocks_ids[] = {
>> +	{ .compatible = "arm,scpi-clocks", },
>> +	{}
>> +};
>
> Did you want a MODULE_DEVICE_TABLE() here?
>

Yes, I do and it's added now.

Regards,
Sudeep