From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753073AbbG3RUL (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Jul 2015 13:20:11 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:31026 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751142AbbG3RUJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Jul 2015 13:20:09 -0400
Message-ID: <55BA5C5C.2050904@oracle.com>
Date: Thu, 30 Jul 2015 13:18:20 -0400
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Andrew Cooper <andrew.cooper3@citrix.com>, Borislav Petkov <bp@alien8.de>
CC: "security@kernel.org" <security@kernel.org>,
        Jan Beulich <jbeulich@suse.com>, Peter Zijlstra <peterz@infradead.org>,
        X86 ML <x86@kernel.org>, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>,
        xen-devel <xen-devel@lists.xen.org>, Andy Lutomirski <luto@kernel.org>,
        Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [Xen-devel] [PATCH v5 0/4] x86: modify_ldt improvement, test,
 and config option
References: <cover.1438061139.git.luto@kernel.org>	<55BA487E.9030708@oracle.com> <20150730160555.GB28617@nazgul.tnic> <55BA4D08.9070306@citrix.com> <55BA5173.401@oracle.com> <55BA59B1.5000600@citrix.com>
In-Reply-To: <55BA59B1.5000600@citrix.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/30/2015 01:06 PM, Andrew Cooper wrote:
> On 30/07/15 17:31, Boris Ostrovsky wrote:
>> On 07/30/2015 12:12 PM, Andrew Cooper wrote:
>>> On 30/07/15 17:05, Borislav Petkov wrote:
>>>> On Thu, Jul 30, 2015 at 11:53:34AM -0400, Boris Ostrovsky wrote:
>>>>> As far as Xen guests are concerned,
>>>>>
>>>>> Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>>> Does that mean, this patch 1/4 fixes the 32bit issue you guys are still
>>>> debugging on the v4 thread? Or does that need more fixing?
>>>>
>>> I was going to say... This v5 pre-dates figuring out what was wrong with
>>> 32bit Xen.  v5 1/4 is still susceptible.
>>>
>>> Boris: does your Tested-by cover v5 + proposed fix?
>>>
>> Only V5, no extra changes.
> Including running the ldt_gdt test?

Yes, except that 32-on-64 doesn't work, but that's not Xen-specific.

Still, user-visible behavior changes.

>
>> And perhaps dropping aliases in xen_alloc_ldt() may be sufficient
>> since with that done we will only have one mapping so a subsequent
>> fault will have "correct" cr2 provided by the hypervisor (from your
>> earlier email it sounded that hypervisor may have been providing
>> incorrect cr2 if alias exists)
> They are sufficient to fix the first of the two bugs, but the free side
> still has no protection against a missing l2, unless I am missing
> something in the rest of the series?

Without aliases a subsequent fault *will* fill correct l2, won't it?

-boris