From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbbG3V1K (ORCPT ); Thu, 30 Jul 2015 17:27:10 -0400 Received: from smtp101.biz.mail.bf1.yahoo.com ([98.139.221.60]:23197 "EHLO smtp101.biz.mail.bf1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbbG3V1J (ORCPT ); Thu, 30 Jul 2015 17:27:09 -0400 X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: U7PEO1oVM1mVp5qxlAad5lIZBDWWcp_Tn9ng8s3QTkgUfJm QP1oXiejGFf_XstZ_9V.wPv5vP_B7SKmm8s1QeG369TindfAf_2l18CbNiQo vx9KuJOf8D50eyB9ivNM4OECKgdEXmSRZshcEyQv6ghGL7DkaEzyeSAfPter wSsuLSrc27VraRkJzxK.xkmg1t_cuTLFI1Hd_C5fMB7ZOKK2YxG8tXmtRwpI 2LW3x1cGyLIj.9t.QXSuOCMZpp85p_mx5Q0VntFVrT4gWg9wcojWlBx_GM.6 6rfQJMHnR0en9JlFFlQ3a462c0btF95AWeqUfCApjzW05pHKrURoHAO7zzPL SeS_g6Fs8FNu8SDpmmIREepWsHU4un3yzgyXshU9i_bi0zTa4cGNxmTVgoSN c9ITeDArhKTVYzkuKKtDiNYiIp51qUEfu.ifef3hzKTcVfaEeaGe1W_el0wy tXhF_CxTGzysF0MV4stH6fRVbN.x.NvHP2NnQ1dG7N_Zutipxx3na2hT1H75 nMtsxa_cAZtg5shXyjtwIczwjjrNwsYYeKA-- X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- To: LKLM Cc: fwngguang.wu@intel.com, Casey Schaufler From: Casey Schaufler Subject: [PATCH] Smack: Three symbols that should be static Message-ID: <55BA96AA.6040605@schaufler-ca.com> Date: Thu, 30 Jul 2015 14:27:06 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Subject: [PATCH] Smack: Three symbols that should be static The kbuild test robot reported a couple of these, and the third showed up by inspection. Making the symbols static is proper. Reported-by: Fengguang Wu Signed-off-by: Casey Schaufler --- security/smack/smack_lsm.c | 4 ++-- security/smack/smackfs.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index cc390bc..54fb3a1 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -291,7 +291,7 @@ static struct smack_known *smk_fetch(const char *name, struct inode *ip, * * Returns the new blob or NULL if there's no memory available */ -struct inode_smack *new_inode_smack(struct smack_known *skp) +static struct inode_smack *new_inode_smack(struct smack_known *skp) { struct inode_smack *isp; @@ -4516,7 +4516,7 @@ static int smack_inode_getsecctx(struct inode *inode, void **ctx, u32 *ctxlen) return 0; } -struct security_hook_list smack_hooks[] = { +static struct security_hook_list smack_hooks[] = { LSM_HOOK_INIT(ptrace_access_check, smack_ptrace_access_check), LSM_HOOK_INIT(ptrace_traceme, smack_ptrace_traceme), LSM_HOOK_INIT(syslog, smack_syslog), diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 11b752b..c20b154 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -139,7 +139,7 @@ struct smack_master_list { struct smack_rule *smk_rule; }; -LIST_HEAD(smack_rule_list); +static LIST_HEAD(smack_rule_list); struct smack_parsed_rule { struct smack_known *smk_subject;