From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbbGaA6y (ORCPT ); Thu, 30 Jul 2015 20:58:54 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:49591 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbbGaA6x (ORCPT ); Thu, 30 Jul 2015 20:58:53 -0400 Message-ID: <55BAC84A.1010007@roeck-us.net> Date: Thu, 30 Jul 2015 17:58:50 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org CC: Jean Delvare , lm-sensors@lm-sensors.org Subject: Re: [PATCH 18/27] hwmon: (g762) Export OF module alias information References: <1438273132-20926-1-git-send-email-javier@osg.samsung.com> <1438273132-20926-19-git-send-email-javier@osg.samsung.com> In-Reply-To: <1438273132-20926-19-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/30/2015 09:18 AM, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c: regardless if the driver was matched using the I2C id_table or the > of_match_table. So technically there's no need for a driver to export > the OF table since currently it's not used. > > In fact, the I2C device ID table is mandatory for I2C drivers since > a i2c_device_id is passed to the driver's probe function even if the > I2C core used the OF table to match the driver. > > And since the I2C core uses different tables, OF-only drivers needs to > have duplicated data that has to be kept in sync and also the dev node > compatible manufacturer prefix is stripped when reporting the MODALIAS. > > To avoid the above, the I2C core behavior may be changed in the future > to not require an I2C device table for OF-only drivers and report the > OF module alias. So, it's better to also export the OF table to prevent > breaking module autoloading if that happens. > > Signed-off-by: Javier Martinez Canillas > Applied. Thanks, Guenter