From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbbGaIRY (ORCPT ); Fri, 31 Jul 2015 04:17:24 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:47337 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbbGaIRS (ORCPT ); Fri, 31 Jul 2015 04:17:18 -0400 X-AuditID: cbfec7f5-f794b6d000001495-d0-55bb2f0a8528 Message-id: <55BB2F09.8000501@samsung.com> Date: Fri, 31 Jul 2015 10:17:13 +0200 From: Robert Baldyga User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, jslaby@suse.cz, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski Subject: Re: [PATCH 0/2] serial: samsung: fix DMA for small FIFO sizes References: <1438247656-24695-1-git-send-email-r.baldyga@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xa7pc+rtDDRY90baYs34Nm0Xz4vVs Fp9/72K1eP3C0OLyrjlsFmcW97JbrD1yl92B3ePEjN8sHvvnrmH36NuyitHjzIIj7B6fN8kF sEZx2aSk5mSWpRbp2yVwZVzddpG94AxXxaa91g2MRzi6GDk5JARMJOa2vWSHsMUkLtxbz9bF yMUhJLCUUeJP21kmCOcZo8Sr/pfMIFW8AloSk98/ZQSxWQRUJf48u88CYrMJ6Ehs+T4BLC4q ECHx9vJJJoh6QYkfk++B1YgIGEoc3L0dbCizwDZGicONbWBFwgJuEm3dnSwQ23oYJU7Pn80G kuAUCJaYduQ6axcjB1CHusSUKbkgYWYBeYnNa94yT2AUmIVkxyyEqllIqhYwMq9iFE0tTS4o TkrPNdIrTswtLs1L10vOz93ECAnxrzsYlx6zOsQowMGoxMMrsHhXqBBrYllxZe4hRgkOZiUR 3vtqu0OFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwJjx JnW95uoH094Ku985/vqSJPO070KPsuMWvNxc8eLU6UtbY5w3ZhVkHKhYPjXlPveH4vIrTx8d FT30+o2Y6NfSezKmJx5t+tYrc46F01wgaqPqjtetnFvZzbiD9nwvXWLtePbjM4uqq1Psz/nd KX9S8v3vycyv/JVL6o/ePLls4vOp7Q+e/+dLVWIpzkg01GIuKk4EAJPuN3FtAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/31/2015 10:04 AM, Krzysztof Kozlowski wrote: > 2015-07-30 18:14 GMT+09:00 Robert Baldyga : >> Hello, >> >> This patch set fixes bug causing serial hang in DMA mode for FIFO sizes >> smaller than cache alignment. The first patch fixes DMA mode entering >> condition to avoid starting with buffer smaller than cache line size. >> Second patch fixes the serial hang bug, which was caused by unproper >> buffer aligning algorithm which assumed that there is always enough >> free space in FIFO for excessive bytes of buffer that is being alligned. >> >> Best regards, >> Robert Baldyga >> >> Marek Szyprowski (1): >> serial: samsung: calculate min_dma_size >> >> Robert Baldyga (1): >> serial: samsung: fix DMA for FIFO smaller than cache line size >> >> drivers/tty/serial/samsung.c | 47 +++++++++++++++++++++++++++++--------------- >> drivers/tty/serial/samsung.h | 1 + >> 2 files changed, 32 insertions(+), 16 deletions(-) > > Does this apply for stable backporting? Or at least fixes tag > indicating a bug? I could not figure this out from description of > first patch. For second patch it seems it applies. These patches are two steps of fixing the bug, so they both apply for stable backporting. > > Anyway I would appreciate a reported-by credits. Sure ;) Thanks, Robert