From: Sudeep Holla <sudeep.holla@arm.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Juri Lelli <Juri.Lelli@arm.com>
Subject: Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling
Date: Fri, 31 Jul 2015 11:35:34 +0100 [thread overview]
Message-ID: <55BB4F76.8090606@arm.com> (raw)
In-Reply-To: <CABb+yY21EXTi___yMumBO+BBtjw5PTnRMWmAjz1jxyHS3q57bw@mail.gmail.com>
On 31/07/15 11:30, Jassi Brar wrote:
> On Fri, Jul 31, 2015 at 3:22 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>>>
>>>> Again, sorry for misleading comment, we do need hrtimer as replied on
>>>> scpi thread. Any other concern with this patch ?
>>>>
>>> Polling by hrtimers is OK. Not to mean this is the best solution for
>>> your platform. Please revise the changelog completely.
>>>
>>
>> OK, how about:
>>
>> "The mailbox core uses jiffy based timer to handle polling for the
>> transmit completion. If the client/protocol have/support notification
>> of the last packet transmit completion via ACK packet, then we tick the
>> Tx state machine immediately in the callback. However if the client
>> doesn't support that mechanism we might end-up waiting for atleast a
>> jiffy even though the remote is ready to receive the next request.
>>
>> This patch switches the timer used for that polling from jiffy-based
>> to hrtimer-based so that we can support polling at much higher time
>> resolution."
>
> Perfect.
>
Thanks, will respin the patches soon.
Regards,
Sudeep
next prev parent reply other threads:[~2015-07-31 10:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 12:28 [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling Sudeep Holla
2015-07-22 12:28 ` [PATCH 2/2] mailbox: arm_mhu: reduce txpoll_period from 10ms to 1 ms Sudeep Holla
2015-07-24 5:02 ` [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling Jassi Brar
2015-07-24 8:47 ` Sudeep Holla
2015-07-27 3:26 ` Jassi Brar
2015-07-27 9:48 ` Sudeep Holla
2015-07-29 8:33 ` Jassi Brar
2015-07-29 8:48 ` Sudeep Holla
2015-07-30 18:11 ` Jassi Brar
2015-07-31 9:52 ` Sudeep Holla
2015-07-31 10:30 ` Jassi Brar
2015-07-31 10:35 ` Sudeep Holla [this message]
2015-07-31 10:48 ` [PATCH v2 " Sudeep Holla
2015-07-31 10:48 ` [PATCH v2 2/2] mailbox: arm_mhu: reduce txpoll_period from 10ms to 1 ms Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB4F76.8090606@arm.com \
--to=sudeep.holla@arm.com \
--cc=Juri.Lelli@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).