From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751972AbbGaKnK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 31 Jul 2015 06:43:10 -0400
Received: from foss.arm.com ([217.140.101.70]:44447 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751337AbbGaKnI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 31 Jul 2015 06:43:08 -0400
Message-ID: <55BB5138.2010004@arm.com>
Date: Fri, 31 Jul 2015 11:43:04 +0100
From: Sudeep Holla <sudeep.holla@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Jassi Brar <jassisinghbrar@gmail.com>
CC: Sudeep Holla <sudeep.holla@arm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        Punit Agrawal <Punit.Agrawal@arm.com>,
        "Jon Medhurst (Tixy)" <tixy@linaro.org>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Kevin Hilman <khilman@kernel.org>
Subject: Re: [PATCH v5 2/8] firmware: add support for ARM System Control and
 Power Interface(SCPI) protocol
References: <1437649828-14540-1-git-send-email-sudeep.holla@arm.com>	<1437649828-14540-3-git-send-email-sudeep.holla@arm.com>	<CABb+yY3cXP07+Go=XUPkuLU7fJER99z4Uyt+wdKpgTDrxeLOCA@mail.gmail.com>	<55B89100.3020802@arm.com>	<CABb+yY1sLcFDh70tmjiaFQPuKTKK_yZvQJ6KD3RAkU9X8aQqtw@mail.gmail.com>	<55B8CC23.5020306@arm.com>	<CABb+yY18VirP5oaJM9bhDyiY5SgDW-xXXY9xv8pqL2uQpT0WBg@mail.gmail.com>	<55BB4274.2050905@arm.com> <CABb+yY0-jVa-ZXpeOCHJoXk9XB5X7-2RnXS=A0NXnFhSANr_Lg@mail.gmail.com>
In-Reply-To: <CABb+yY0-jVa-ZXpeOCHJoXk9XB5X7-2RnXS=A0NXnFhSANr_Lg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 31/07/15 11:38, Jassi Brar wrote:
> On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>> I forgot to mention, we have a the following description in
>> mbox_client_txdone which is misleading:
>>
>> "The client/protocol had received some 'ACK' packet and it notifies the
>> API that the last packet was sent successfully. This only works if the
>> controller can't sense TX-Done."
>>
>> which is clearly not the case in SCPI. IMO we may have to reword that.
>>
> Yes. And also see whether it could race with polling driven tx_tick.
>

Yes I am also looking at that now while I am trying to check if
TXDONE_BY_ACK works on Juno, will keep you posted.

Regards,
Sudeep