From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383AbbGaQRi (ORCPT ); Fri, 31 Jul 2015 12:17:38 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:33301 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbbGaQRh (ORCPT ); Fri, 31 Jul 2015 12:17:37 -0400 Message-ID: <55BB9F36.8040809@gmail.com> Date: Fri, 31 Jul 2015 18:15:50 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Ricardo Ribalda Delgado , Alan Tull , Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds/led-class: Add missing put_device() References: <1438342581-9763-1-git-send-email-ricardo.ribalda@gmail.com> In-Reply-To: <1438342581-9763-1-git-send-email-ricardo.ribalda@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Thanks for the update. On 31.07.2015 13:36, Ricardo Ribalda Delgado wrote: > Devices found by class_find_device must be freed with put_device(). > Otherwise the reference count will not work properly. > > Fixes: a96aa64cb572 ("leds/led-class: Handle LEDs with the same name") > Reported-by: Alan Tull > Signed-off-by: Ricardo Ribalda Delgado > --- > Thanks Alan for the initial report and Jacek for the review > > v2: Changes from Jacek Anaszewski > If ret <= len device was not relased > > drivers/leds/led-class.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index beabfbc6f7cd..ca51d58bed24 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -228,12 +228,15 @@ static int led_classdev_next_name(const char *init_name, char *name, > { > unsigned int i = 0; > int ret = 0; > + struct device *dev; > > strlcpy(name, init_name, len); > > - while (class_find_device(leds_class, NULL, name, match_name) && > - (ret < len)) > + while ((ret < len) && > + (dev = class_find_device(leds_class, NULL, name, match_name))) { > + put_device(dev); > ret = snprintf(name, len, "%s_%u", init_name, ++i); > + } > > if (ret >= len) > return -ENOMEM; > Acked-by: Jacek Anaszewski -- Best Regards, Jacek Anaszewski