From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751256AbbHAKlG (ORCPT <rfc822;w@1wt.eu>);
	Sat, 1 Aug 2015 06:41:06 -0400
Received: from mout.web.de ([212.227.15.14]:53668 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751010AbbHAKlE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 1 Aug 2015 06:41:04 -0400
Subject: Re: [PATCH 03/11] ocfs2: Less checks in ocfs2_rename() after error
 detection
To: Dan Carpenter <dan.carpenter@oracle.com>
References: <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <5455FC05.4010606@users.sourceforge.net>
 <alpine.DEB.2.02.1411021150540.2239@localhost6.localdomain6>
 <55992DF0.5030205@users.sourceforge.net>
 <55993170.6060306@users.sourceforge.net> <20150706085414.GD28762@mwanda>
Cc: Joel Becker <jlbec@evilplan.org>, Mark Fasheh <mfasheh@suse.com>,
        ocfs2-devel@oss.oracle.com, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <55BCA226.2020401@users.sourceforge.net>
Date: Sat, 1 Aug 2015 12:40:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150706085414.GD28762@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:eg7nzH1AxuC3nAN8VKrWjl1ralQHM7isZvuHmrXlsmrfuMvMZJr
 5ch4EVPdUhTM75P0S76G7haCvuzyiCMAt2yb45+mu1t0bISGX85ahUsqS9dTZO1Ni60IvQN
 Jud1SwCgWM3qXYUshCZxHk1F+e456jphoKY15mAMWFnIly/+GwsO44KzILH06KiR18fhig2
 UwAcO9PZU6bhJ/Ii0h9ng==
X-UI-Out-Filterresults: notjunk:1;V01:K0:XCtBTJQoABg=:aF6gEpZ77n2tkyKNEm58BG
 GoSGUWBguNWaUy5t9grckuFQuVpnu9jw6L1Z9p6Baonb50GQ6PGcUeXdPJvQwtEGNK9XKK1IL
 VgxFgDg5fpTC2o9omJ94/eAtxd56biZ2uHZ0CrYDd2zXR2hL+hMFqay9b5L3YWKcQo3mBflHJ
 QKX5kkg7dJVY2Jgx/tmShBFOfEmoq+3mth2GedmNQOv7BS6hvjJ8dKAZALtT7ZgqZddFh2CPx
 HLQHCbz2NvHp7IyiFNIBBSpygGGCU4xXa77E6aFfSO8cZrTASuZDEeHOdibpGLrCq0NtHM7sx
 KTmEr13opcGcnWD416e2NBSldSlxZ3xkbxUREiR4rNhPYpuDQkJ/1BA5jZtdW2CLbZfg1nKlX
 atSbGQW/qgHHEa5hxo2xFc9znASwA1ks+EuHzGftw8WsYGXVrDx0uzfavY8mLo789qTuSD5CQ
 8GGZvk9jQa60pFN5lTnmWEqLc5G5q4GPc8Encs0ftzgkjes9vwc2pcYRExB/GVRRj4E/Ndgb/
 DM7rVqJZbvgtjrt6S0ChsIH+1gm9p1cc33N39Ju2/GxpDJz/Kop5B64tmslqk5iofnborqGVy
 SquZxI2woLcGgcu4M1t4Ba+n03xvhDS5DPTIx7v7jjxQr3v7fuJ5PJWF7FN+9Pe4bgm8lv0ru
 7f137+t7/6MNYdwcZjC1o4/ZiG14WLQPdaIMu6ux3WReuzLQXx3RwquQe9frMYX2ioe0=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sat, 4 Jul 2015 15:30:18 +0200
>>
>> Skip checks for a few variables in three error handling cases within
>> the ocfs2_rename() function by adjustment of a few jump targets
>> according to the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> 
> I don't think this is an improvement.

How do you think about the other update suggestions from this patch series?

Can the corresponding source code review be continued?

Regards,
Markus