From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbbHBRTd (ORCPT ); Sun, 2 Aug 2015 13:19:33 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:45312 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbbHBRTc (ORCPT ); Sun, 2 Aug 2015 13:19:32 -0400 Subject: Re: [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for runtime resume To: Irina Tirdea , linux-iio@vger.kernel.org References: <1437671702-20994-1-git-send-email-irina.tirdea@intel.com> <1437671702-20994-2-git-send-email-irina.tirdea@intel.com> Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Vlad Dogaru From: Jonathan Cameron Message-ID: <55BE5122.2060405@kernel.org> Date: Sun, 2 Aug 2015 18:19:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1437671702-20994-2-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/07/15 18:15, Irina Tirdea wrote: > Runtime resume function is called with the data->mutex lock held. > Add a comment to indicate this. > > Signed-off-by: Irina Tirdea Sensible follow up to Hartmut's patches. Applied to the togreg branch of iio.git Thanks, Jonathan > --- > drivers/iio/magnetometer/bmc150_magn.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c > index 074a99d..d66f8cf 100644 > --- a/drivers/iio/magnetometer/bmc150_magn.c > +++ b/drivers/iio/magnetometer/bmc150_magn.c > @@ -1043,6 +1043,9 @@ static int bmc150_magn_runtime_suspend(struct device *dev) > return 0; > } > > +/* > + * Should be called with data->mutex held. > + */ > static int bmc150_magn_runtime_resume(struct device *dev) > { > struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev)); >