linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>,
	Irina Tirdea <irina.tirdea@intel.com>,
	linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tools: iio: print error message when buffer enable fails
Date: Sun, 2 Aug 2015 18:39:56 +0100	[thread overview]
Message-ID: <55BE55EC.3010206@kernel.org> (raw)
In-Reply-To: <55B282A8.40903@gmx.de>

On 24/07/15 19:23, Hartmut Knaack wrote:
> Irina Tirdea schrieb am 24.07.2015 um 15:28:
>> Running generic_buffer without enabling any channel of the
>> sensor will fail without printing any error message.
>>
>> Add an error message that indicates buffer enable failed.
>>
>> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Applied.

Thanks

Jonathan
>> ---
>>  tools/iio/generic_buffer.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
>> index 32f389eb..9f7b85b 100644
>> --- a/tools/iio/generic_buffer.c
>> +++ b/tools/iio/generic_buffer.c
>> @@ -364,8 +364,11 @@ int main(int argc, char **argv)
>>  
>>  	/* Enable the buffer */
>>  	ret = write_sysfs_int("enable", buf_dir_name, 1);
>> -	if (ret < 0)
>> +	if (ret < 0) {
>> +		fprintf(stderr,
>> +			"Failed to enable buffer: %s\n", strerror(-ret));
>>  		goto error_free_buf_dir_name;
>> +	}
>>  
>>  	scan_size = size_from_channelarray(channels, num_channels);
>>  	data = malloc(scan_size * buf_len);
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


      reply	other threads:[~2015-08-02 17:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 13:28 [PATCH v2 0/2] tools: iio: generic_buffer fixes Irina Tirdea
2015-07-24 13:28 ` [PATCH v2 1/2] tools: iio: fix mask for 32 bit sensor data Irina Tirdea
2015-08-02 17:38   ` Jonathan Cameron
2015-07-24 13:28 ` [PATCH v2 2/2] tools: iio: print error message when buffer enable fails Irina Tirdea
2015-07-24 18:23   ` Hartmut Knaack
2015-08-02 17:39     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BE55EC.3010206@kernel.org \
    --to=jic23@kernel.org \
    --cc=irina.tirdea@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).