From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753805AbbHCMnP (ORCPT ); Mon, 3 Aug 2015 08:43:15 -0400 Received: from foss.arm.com ([217.140.101.70]:53367 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786AbbHCMnN (ORCPT ); Mon, 3 Aug 2015 08:43:13 -0400 Message-ID: <55BF61DD.7020003@arm.com> Date: Mon, 03 Aug 2015 13:43:09 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Jon Medhurst (Tixy)" , Liviu Dudau CC: Sudeep Holla , "arm@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Olof Johansson , Kevin Hilman , Punit Agrawal , Lorenzo Pieralisi , Arnd Bergmann Subject: Re: [PATCH v6 6/8] arm64: dts: add SRAM, MHU mailbox and SCPI support on Juno References: <1438364591-1144-1-git-send-email-sudeep.holla@arm.com> <1438364591-1144-7-git-send-email-sudeep.holla@arm.com> <20150803112353.GV20890@e106497-lin.cambridge.arm.com> <1438602393.5218.3.camel@linaro.org> In-Reply-To: <1438602393.5218.3.camel@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/15 12:46, Jon Medhurst (Tixy) wrote: > On Mon, 2015-08-03 at 12:23 +0100, Liviu Dudau wrote: >> On Fri, Jul 31, 2015 at 06:43:09PM +0100, Sudeep Holla wrote: >>> This patch adds support for the MHU mailbox peripheral used on Juno by >>> application processors to communicate with remote SCP handling most of >>> the CPU/system power management. It also adds the SRAM reserving the >>> shared memory and SCPI message protocol using that shared memory. >>> >>> Signed-off-by: Sudeep Holla >>> Acked-by: Liviu Dudau >>> Cc: Jon Medhurst (Tixy) >>> --- >>> arch/arm64/boot/dts/arm/juno-base.dtsi | 54 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 54 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi >>> index e3ee96036eca..c624208edef6 100644 >>> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi >>> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > [...] >>> + scpi { >>> + compatible = "arm,scpi"; >>> + mboxes = <&mailbox 1>; >>> + shmem = <&cpu_scp_hpri>; >>> + >>> + clocks { >>> + compatible = "arm,scpi-clocks"; >>> + >>> + scpi_dvfs: scpi_clocks@0 { >>> + compatible = "arm,scpi-dvfs-clocks"; >>> + #clock-cells = <1>; >>> + clock-indices = <0>, <1>, <2>; >>> + clock-output-names = "atlclk", "aplclk","gpuclk"; >>> + }; >>> + scpi_clk: scpi_clocks@3 { >>> + compatible = "arm,scpi-variable-clocks"; >>> + #clock-cells = <1>; >>> + clock-indices = <3>, <4>; >>> + clock-output-names = "pxlclk0", "pxlclk1"; >>> + }; >>> + }; >>> + }; >>> + >> >> Sorry for noticing this after the ACK, is there any reason why the scpi node is not inside >> the juno-clocks.dtsi file? > > Because SCPI is not just about clocks? Just happens that these first > patches are but there's thermal sensors and other things as well. > I think we cross posted. Anyways I completely agree with you. However I wanted the clock nodes to be put in juno-clock.dtsi but got into horrible issue with the way we include headers. It may need some reworking to get that working. The idea was: /* in juno-base.dtsi */ SCPI: scpi { compatible = "arm,scpi"; mboxes = <&mailbox 1>; shmem = <&cpu_scp_hpri>; ... }; /* in juno-clock.dtsi */ &SCPI { clocks { compatible = "arm,scpi-clocks"; scpi_dvfs: scpi_clocks@0 { compatible = "arm,scpi-dvfs-clocks"; #clock-cells = <1>; clock-indices = <0>, <1>, <2>; clock-output-names = "atlclk","aplclk","gpuclk"; }; }; I will look at that when I get some time. There are many DTS files already using something similar. Regards, Sudeep