Re: [PATCH] Check return code from pdc20621_i2c_read()

Sergei Shtylyov
2015-08-03T15:42:10Z

On 08/02/2015 08:55 PM, Tomer Barletz wrote:

>> Please use pr_err() instead. And "0x%d" makes no sense at all, please use "%#x" instead.

> Yeah, not sure what I was drinking before writing this 0x%d thing...

> Regarding the pr_err() - it is not used at all in this file, and
> printk() is used instead.

The problem is these printk() calls cause complaints from
scripts/checkpatch.pl.

> Wouldn't it be better to leave it with
> printk for this change, then have another change that replaces
> printk()s with pr_err()s?

Probably yes...

> --Tomer

MBR, Sergei