Re: [PATCH] Check return code from pdc20621_i2c_read()

Tomer Barletz
2015-08-02T17:56:01Z

Re-sending in plain-text.

On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:

> Please use pr_err() instead. And "0x%d" makes no sense at all, please use "%#x" instead.
>

Yeah, not sure what I was drinking before writing this 0x%d thing...

Regarding the pr_err() - it is not used at all in this file, and
printk() is used instead. Wouldn't it be better to leave it with
printk for this change, then have another change that replaces
printk()s with pr_err()s?

--Tomer

On Sun, Aug 2, 2015 at 10:53 AM, Tomer Barletz <barletz@gmail.com> wrote:
>
> On Sun, Aug 2, 2015 at 4:09 AM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
>
>> Please use pr_err() instead. And "0x%d" makes no sense at all, please
>> use "%#x" instead.
>>
>
> Yeah, not sure what I was drinking before writing this 0x%d thing...
>
> Regarding the pr_err() - it is not used at all in this file, and printk() is
> used instead. Wouldn't it be better to leave it with printk for this change,
> then have another change that replaces printk()s with pr_err()s?
>
> --Tomer
>