Re: [PATCH] Check return code from pdc20621_i2c_read()

Sergei Shtylyov
2015-08-03T15:52:16Z

On 08/03/2015 06:42 PM, Sergei Shtylyov wrote:

>>> Please use pr_err() instead. And "0x%d" makes no sense at all, please
>>> use "%#x" instead.

>> Yeah, not sure what I was drinking before writing this 0x%d thing...

>> Regarding the pr_err() - it is not used at all in this file, and
>> printk() is used instead.

Didn't notice before: the patch subject should start with the driver name
and a colon, "sats_sx4: ".

>> --Tomer

MBR, Sergei