From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbbHCPvQ (ORCPT ); Mon, 3 Aug 2015 11:51:16 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:43269 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbbHCPvP (ORCPT ); Mon, 3 Aug 2015 11:51:15 -0400 Message-ID: <55BF8DE9.5050907@ti.com> Date: Mon, 3 Aug 2015 21:21:05 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Roger Quadros , CC: , , , , , , Subject: Re: [PATCH v2 3/3] ARM: dts: dra7: Add scm_conf@1c04 node References: <1437992850-6008-1-git-send-email-rogerq@ti.com> <1437992850-6008-4-git-send-email-rogerq@ti.com> In-Reply-To: <1437992850-6008-4-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On Monday 27 July 2015 03:57 PM, Roger Quadros wrote: > This region contains CTRL_CORE_SMA_SW2..9 registers which > are not specific to any domain and can be reasonably > accessed via syscon driver. > > Signed-off-by: Roger Quadros > --- > arch/arm/boot/dts/dra7.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 913032b..43b5074 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -149,6 +149,13 @@ > pinctrl-single,register-width = <32>; > pinctrl-single,function-mask = <0x3fffffff>; > }; > + > + scm_conf1: scm_conf@1c04 { > + compatible = "syscon"; > + reg = <0x1c04 0x0020>; > + #address-cells = <1>; > + #size-cells = <1>; Why do you need address-cells and size-cells property here? AFAIK it is usually used to decode childs reg property. Thanks Kishon