public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pengyu Ma <pengyu.ma@windriver.com>
To: <jic23@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-iio@vger.kernel.org>, <lars@metafoo.de>
Subject: Re: [PATCH V2] iio: declare struct to fix warning
Date: Tue, 4 Aug 2015 15:52:29 +0800	[thread overview]
Message-ID: <55C06F3D.5080803@windriver.com> (raw)
In-Reply-To: <1438569580-3712-1-git-send-email-pengyu.ma@windriver.com>

If this patch is fine, could somebody help me to merge into upstream kernel?

Thanks,
Pengyu

On 08/03/2015 10:39 AM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>    int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>             struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
>   include/linux/iio/trigger.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..974cf73 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,10 @@ struct iio_subirq {
>   	bool enabled;
>   };
>   
> +/* forward declaration */
> +struct iio_dev;
> +struct iio_trigger;
> +
>   /**
>    * struct iio_trigger_ops - operations structure for an iio_trigger.
>    * @owner:		used to monitor usage count of the trigger.


  reply	other threads:[~2015-08-04  7:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  2:39 [PATCH V2] iio: declare struct to fix warning Pengyu Ma
2015-08-04  7:52 ` Pengyu Ma [this message]
2015-08-04  7:54   ` Lars-Peter Clausen
2015-08-04  7:56     ` Pengyu Ma
2015-08-04  7:58       ` Crt Mori
2015-08-04  7:59       ` Lars-Peter Clausen
2015-08-04  8:03 ` Daniel Baluta
2015-08-04  8:11   ` Pengyu Ma
2015-08-04  8:14     ` Daniel Baluta
2015-08-08 11:27       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C06F3D.5080803@windriver.com \
    --to=pengyu.ma@windriver.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox