From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932364AbbHDIKm (ORCPT ); Tue, 4 Aug 2015 04:10:42 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:55529 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753615AbbHDIKk (ORCPT ); Tue, 4 Aug 2015 04:10:40 -0400 Message-ID: <55C0737A.7020906@ti.com> Date: Tue, 4 Aug 2015 11:10:34 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , CC: , , , , , , Subject: Re: [PATCH v2 3/3] ARM: dts: dra7: Add scm_conf@1c04 node References: <1437992850-6008-1-git-send-email-rogerq@ti.com> <1437992850-6008-4-git-send-email-rogerq@ti.com> <55BF8DE9.5050907@ti.com> In-Reply-To: <55BF8DE9.5050907@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/15 18:51, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Monday 27 July 2015 03:57 PM, Roger Quadros wrote: >> This region contains CTRL_CORE_SMA_SW2..9 registers which >> are not specific to any domain and can be reasonably >> accessed via syscon driver. >> >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/dra7.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 913032b..43b5074 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -149,6 +149,13 @@ >> pinctrl-single,register-width = <32>; >> pinctrl-single,function-mask = <0x3fffffff>; >> }; >> + >> + scm_conf1: scm_conf@1c04 { >> + compatible = "syscon"; >> + reg = <0x1c04 0x0020>; >> + #address-cells = <1>; >> + #size-cells = <1>; > > Why do you need address-cells and size-cells property here? AFAIK it is usually > used to decode childs reg property. Right. I'll remove them. cheers, -roger