From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755151AbbHDIL2 (ORCPT ); Tue, 4 Aug 2015 04:11:28 -0400 Received: from mail.windriver.com ([147.11.1.11]:36079 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754959AbbHDILZ (ORCPT ); Tue, 4 Aug 2015 04:11:25 -0400 Subject: Re: [PATCH V2] iio: declare struct to fix warning To: Daniel Baluta References: <1438569580-3712-1-git-send-email-pengyu.ma@windriver.com> CC: Jonathan Cameron , Linux Kernel Mailing List , "linux-iio@vger.kernel.org" From: Pengyu Ma Message-ID: <55C073A7.10907@windriver.com> Date: Tue, 4 Aug 2015 16:11:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2015 04:03 PM, Daniel Baluta wrote: > On Mon, Aug 3, 2015 at 5:39 AM, Pengyu Ma wrote: >> When compile iio related driver the following warning shown: >> >> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger' >> declared inside parameter list >> int (*set_trigger_state)(struct iio_trigger *trig, bool state); >> >> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev' >> declared inside parameter list >> struct iio_dev *indio_dev); >> >> 'struct iio_dev' and 'struct iio_trigger' was used before declaration, >> forward declaration for these structs to fix warning. >> >> Signed-off-by: Pengyu Ma >> --- >> include/linux/iio/trigger.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h >> index fa76c79..974cf73 100644 >> --- a/include/linux/iio/trigger.h >> +++ b/include/linux/iio/trigger.h >> @@ -18,6 +18,10 @@ struct iio_subirq { >> bool enabled; >> }; >> >> +/* forward declaration */ > I would remove this comment. It doesn't says much. OK, Do I need a v3 review or you apply it with your modification directly? Pengyu > >> +struct iio_dev; >> +struct iio_trigger; >> + >> /** >> * struct iio_trigger_ops - operations structure for an iio_trigger. >> * @owner: used to monitor usage count of the trigger. > thanks, > Daniel.