From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755493AbbHDIkn (ORCPT <rfc822;w@1wt.eu>);
	Tue, 4 Aug 2015 04:40:43 -0400
Received: from arroyo.ext.ti.com ([192.94.94.40]:56968 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754185AbbHDIkk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 4 Aug 2015 04:40:40 -0400
Message-ID: <55C07A7F.9070309@ti.com>
Date: Tue, 4 Aug 2015 11:40:31 +0300
From: Roger Quadros <rogerq@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>
CC: Chanwoo Choi <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] extcon: signedness bugs break error handling
References: <20150804074723.GC10867@mwanda>
In-Reply-To: <20150804074723.GC10867@mwanda>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/08/15 10:47, Dan Carpenter wrote:
> Unsigned is never less than zero so this error handling won't work.
> 
> Fixes: be052cc87745 ('extcon: Fix hang and extcon_get/set_cable_state().')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan.

Reviewed-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 8301a72..da2fb6c 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)
>  
>  static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
>  {
> -	unsigned int id;
> +	int id;
>  
>  	if (edev->max_supported == 0)
>  		return -EINVAL;
> @@ -379,7 +379,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_);
>   */
>  int extcon_get_cable_state(struct extcon_dev *edev, const char *cable_name)
>  {
> -	unsigned int id;
> +	int id;
>  
>  	id = find_cable_id_by_name(edev, cable_name);
>  	if (id < 0)
> @@ -430,7 +430,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_);
>  int extcon_set_cable_state(struct extcon_dev *edev,
>  			const char *cable_name, bool cable_state)
>  {
> -	unsigned int id;
> +	int id;
>  
>  	id = find_cable_id_by_name(edev, cable_name);
>  	if (id < 0)
>